Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(peer-deps): use uws fork #2781

Merged
merged 2 commits into from
Aug 24, 2018
Merged

build(peer-deps): use uws fork #2781

merged 2 commits into from
Aug 24, 2018

Conversation

iCrawl
Copy link
Member

@iCrawl iCrawl commented Aug 22, 2018

Please describe the changes this PR makes and why it should be merged:

Should be pretty evident why we do this.
We do not have to rely on the broken NPM package that's currently out there and can maintain a variety of node versions on our own.

Additionally resolves #2685

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@iCrawl iCrawl merged commit 9b329a4 into master Aug 24, 2018
@iCrawl iCrawl deleted the uws branch August 24, 2018 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

uws seems to be unmaintained
1 participant