refactor!: return void on bans/kick/addRole/removeRole methods #10714
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Jiralite
reviewed
Jan 19, 2025
BREAKING CHANGE: The following methods don't return anything: `GuildMember#ban`, `GuildMember#kick`, `GuildMemberManager#ban`, `GuildMemberManager#unban`, `GuildMemberManager#kick`, `GuildMemberManager#addRole`, `GuildMemberManager#removeRole`, `GuildBanManager#create`, and `GuildBanManager#remove`.
almeidx
force-pushed
the
refactor/bans-return-user-id
branch
from
9c78ff4 to
e2a2f30
Compare
almeidx
changed the title
Jiralite
approved these changes
Jan 20, 2025
vladfrangu
approved these changes
Jan 21, 2025
didinele
approved these changes
Jan 24, 2025
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: The following methods now always return the user's id:
GuildMember#ban,GuildMember#kick,GuildMemberManager#ban,GuildMemberManager#unban,GuildMemberManager#kick,GuildMemberManager#addRole,GuildMemberManager#removeRole,GuildBanManager#create, andGuildBanManager#remove.Previously, these methods tried to return a cached user or member object, but this was unreliable and required callers to handle varying return types.
If the caller needs user or member data, they can fetch or retrieve it from the cache before invoking these methods.