Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(interactions): options should be optional #10683

Merged
merged 1 commit into from
Jan 3, 2025
Merged

fix(interactions): options should be optional #10683

merged 1 commit into from
Jan 3, 2025

Conversation

Jiralite
Copy link
Member

@Jiralite Jiralite commented Jan 3, 2025

Please describe the changes this PR makes and why it should be merged:
Mistakenly made required in #10512.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the core 3.0.0 milestone Jan 3, 2025
@Jiralite Jiralite requested a review from a team as a code owner January 3, 2025 17:34
@vercel Vercel
Copy link

vercel bot commented Jan 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Jan 3, 2025 5:34pm
discord-js-guide ⬜️ Ignored (Inspect) Jan 3, 2025 5:34pm

@Jiralite Jiralite mentioned this pull request Jan 3, 2025
Merged
@kodiakhq kodiakhq bot merged commit 28a2503 into main Jan 3, 2025
10 checks passed
@kodiakhq kodiakhq bot deleted the fix/optional-options branch January 3, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@almeidx almeidx almeidx approved these changes

@didinele didinele didinele approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@kyranet kyranet Awaiting requested review from kyranet kyranet is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

Assignees
No one assigned
Labels
packages:core semver:patch
Projects
discord.js
Archived in project
Milestone
core 3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@Jiralite @vladfrangu @didinele @almeidx