Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(FetchApplicationCommandOptions): Use Locale over LocaleString #10625

Merged
merged 2 commits into from
Nov 29, 2024

Conversation

Jiralite
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
LocaleString is deprecated. Switching to Locale.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Jiralite Jiralite added this to the discord.js 15.0.0 milestone Nov 28, 2024
@Jiralite Jiralite requested a review from a team as a code owner November 28, 2024 12:07
Copy link

vercel bot commented Nov 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:54am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 29, 2024 9:54am

@almeidx
Copy link
Member

almeidx commented Nov 28, 2024

This needs a rebase

@kodiakhq kodiakhq bot merged commit 8efb72e into main Nov 29, 2024
8 checks passed
@kodiakhq kodiakhq bot deleted the refactor/djs-locale branch November 29, 2024 09:57
Jiralite added a commit that referenced this pull request Dec 5, 2024
…ring` (#10625)

refactor(FetchApplicationCommandOptions): prefer `Locale`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants