Skip to content

Conversation

@sdanialraza
Copy link
Member

Please describe the changes this PR makes and why it should be merged:
Adds iterator and non-iterator variants for requesting soundboard sounds for core

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

@vercel
Copy link

vercel bot commented Nov 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 0:29am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 0:29am

@codecov
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 38.67%. Comparing base (6df42db) to head (6325c4f).
⚠️ Report is 287 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10608      +/-   ##
==========================================
+ Coverage   38.64%   38.67%   +0.02%     
==========================================
  Files         239      239              
  Lines       14664    14653      -11     
  Branches     1385     1385              
==========================================
  Hits         5667     5667              
+ Misses       8985     8974      -11     
  Partials       12       12              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Jiralite Jiralite requested a review from kyranet November 19, 2024 22:38
@sdanialraza sdanialraza marked this pull request as ready for review November 26, 2024 12:54
@sdanialraza sdanialraza requested review from a team as code owners November 26, 2024 12:54
@Jiralite Jiralite added this to the core 3.0.0 milestone Dec 8, 2024
@Jiralite Jiralite removed their request for review January 28, 2025 12:27
@kodiakhq kodiakhq bot merged commit 6e61ec6 into discordjs:main Jan 28, 2025
7 checks passed
@sdanialraza sdanialraza deleted the feat/add-request-soundboard-sounds branch January 28, 2025 19:08
Jiralite pushed a commit that referenced this pull request Nov 12, 2025
* feat(Client): add request soundboard sounds

* docs: add `guildId` to example

Co-authored-by: Almeida <github@almeidx.dev>

* refactor: remove `groupBy` polyfill

---------

Co-authored-by: Almeida <github@almeidx.dev>
Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants