Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove ws dependency #10180

Merged
merged 3 commits into from
Mar 31, 2024
Merged

chore: remove ws dependency #10180

merged 3 commits into from
Mar 31, 2024

Conversation

Qjuh
Copy link
Contributor

@Qjuh Qjuh commented Mar 17, 2024

Please describe the changes this PR makes and why it should be merged:

Remove the ws dependency of discord.jsmain library which is not used anymore since incorporating @discordjs/ws into main library.

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

@Qjuh Qjuh requested review from a team and iCrawl as code owners March 17, 2024 09:19
@Qjuh Qjuh requested review from vladfrangu, kyranet and SpaceEEC March 17, 2024 09:19
Copy link

vercel bot commented Mar 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 9:34am
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Mar 25, 2024 9:34am

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We removed djs from djs

@kodiakhq kodiakhq bot merged commit 654f1a4 into discordjs:main Mar 31, 2024
6 checks passed
@Qjuh Qjuh deleted the chore/remove-ws-dep branch April 15, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

7 participants