Skip to content

Commit 904aecf

Browse files
types: don't use readonly arrays in interfaces (#4794)
This reverts some of the changes in f451be0 so that this works: ```ts const embed: MessageEmbedOptions = { fields: [{ // fixed stuff }], }; if (/* condition */) { embed.fields.push({ // conditional stuff }); } ``` See #4692 (comment).
1 parent a28754b commit 904aecf

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

typings/index.d.ts

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2198,11 +2198,11 @@ declare module 'discord.js' {
21982198
}
21992199

22002200
interface AwaitMessagesOptions extends MessageCollectorOptions {
2201-
errors?: readonly string[];
2201+
errors?: string[];
22022202
}
22032203

22042204
interface AwaitReactionsOptions extends ReactionCollectorOptions {
2205-
errors?: readonly string[];
2205+
errors?: string[];
22062206
}
22072207

22082208
interface BanOptions {
@@ -2474,7 +2474,7 @@ declare module 'discord.js' {
24742474
}
24752475

24762476
interface FetchMembersOptions {
2477-
user?: UserResolvable | readonly UserResolvable[];
2477+
user?: UserResolvable | UserResolvable[];
24782478
query?: string;
24792479
limit?: number;
24802480
withPresences?: boolean;
@@ -2557,7 +2557,7 @@ declare module 'discord.js' {
25572557
type GuildChannelResolvable = Snowflake | GuildChannel;
25582558

25592559
interface GuildCreateChannelOptions {
2560-
permissionOverwrites?: readonly OverwriteResolvable[] | Collection<Snowflake, OverwriteResolvable>;
2560+
permissionOverwrites?: OverwriteResolvable[] | Collection<Snowflake, OverwriteResolvable>;
25612561
topic?: string;
25622562
type?: Exclude<
25632563
keyof typeof ChannelType | ChannelType,
@@ -2602,13 +2602,13 @@ declare module 'discord.js' {
26022602
}
26032603

26042604
interface GuildEmojiCreateOptions {
2605-
roles?: Collection<Snowflake, Role> | readonly RoleResolvable[];
2605+
roles?: Collection<Snowflake, Role> | RoleResolvable[];
26062606
reason?: string;
26072607
}
26082608

26092609
interface GuildEmojiEditData {
26102610
name?: string;
2611-
roles?: Collection<Snowflake, Role> | readonly RoleResolvable[];
2611+
roles?: Collection<Snowflake, Role> | RoleResolvable[];
26122612
}
26132613

26142614
type GuildFeatures =
@@ -2762,8 +2762,8 @@ declare module 'discord.js' {
27622762
url?: string;
27632763
timestamp?: Date | number;
27642764
color?: ColorResolvable;
2765-
fields?: readonly EmbedFieldData[];
2766-
files?: readonly (MessageAttachment | string | FileOptions)[];
2765+
fields?: EmbedFieldData[];
2766+
files?: (MessageAttachment | string | FileOptions)[];
27672767
author?: Partial<MessageEmbedAuthor> & { icon_url?: string; proxy_icon_url?: string };
27682768
thumbnail?: Partial<MessageEmbedThumbnail> & { proxy_url?: string };
27692769
image?: Partial<MessageEmbedImage> & { proxy_url?: string };
@@ -2813,7 +2813,7 @@ declare module 'discord.js' {
28132813
embed?: MessageEmbed | MessageEmbedOptions;
28142814
disableMentions?: 'none' | 'all' | 'everyone';
28152815
allowedMentions?: MessageMentionOptions;
2816-
files?: readonly (FileOptions | BufferResolvable | Stream | MessageAttachment)[];
2816+
files?: (FileOptions | BufferResolvable | Stream | MessageAttachment)[];
28172817
code?: string | boolean;
28182818
split?: boolean | SplitOptions;
28192819
reply?: UserResolvable;
@@ -3166,10 +3166,10 @@ declare module 'discord.js' {
31663166
avatarURL?: string;
31673167
tts?: boolean;
31683168
nonce?: string;
3169-
embeds?: readonly (MessageEmbed | object)[];
3169+
embeds?: (MessageEmbed | object)[];
31703170
disableMentions?: 'none' | 'all' | 'everyone';
31713171
allowedMentions?: MessageMentionOptions;
3172-
files?: readonly (FileOptions | BufferResolvable | Stream | MessageAttachment)[];
3172+
files?: (FileOptions | BufferResolvable | Stream | MessageAttachment)[];
31733173
code?: string | boolean;
31743174
split?: boolean | SplitOptions;
31753175
}

0 commit comments

Comments
 (0)