Skip to content

types: don't use readonly arrays in interfaces #4794

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2020
Merged

types: don't use readonly arrays in interfaces #4794

merged 1 commit into from
Sep 5, 2020

Conversation

@cherryblossom000
Copy link
Contributor

@cherryblossom000 cherryblossom000 commented Sep 5, 2020 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

This reverts some of the changes in f451be0 so that this works:

const embed: MessageEmbedOptions = {
  fields: [{
    // fixed stuff
  }],
};
if (/* condition */) {
  embed.fields.push({
    // conditional stuff
  });
}

See #4692 (comment).

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@cherryblossom000 cherryblossom000 mentioned this pull request Sep 5, 2020
Merged
5 tasks
@cherryblossom000
types: don't use readonly arrays in interfaces
ec96d12 
This reverts some of the changes in f451be0 so that this works:

```ts
const embed: MessageEmbedOptions = {
  fields: [{
    // fixed stuff
  }],
};
if (/* condition */) {
  embed.fields.push({
    // conditional stuff
  });
}
```

See #4692 (comment).
@iCrawl iCrawl requested review from kyranet and vladfrangu September 5, 2020 08:21
@iCrawl iCrawl merged commit 904aecf into discordjs:master Sep 5, 2020
@cherryblossom000 cherryblossom000 deleted the typings branch September 8, 2020 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cherryblossom000 @vladfrangu @iCrawl @kyranet