Skip to content

Conversation

@Jiralite
Copy link
Member

@Jiralite Jiralite commented Aug 7, 2025

@vercel
Copy link

vercel bot commented Aug 7, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
discord-api-types Ready Ready Preview Comment Aug 29, 2025 10:23am

Qjuh
Qjuh previously requested changes Aug 7, 2025
@Jiralite Jiralite marked this pull request as draft August 26, 2025 00:42
@Jiralite Jiralite marked this pull request as ready for review August 28, 2025 23:05
@Jiralite Jiralite requested a review from vladfrangu August 28, 2025 23:06
@Jiralite Jiralite force-pushed the feat/select-in-modals branch from 65ea7a5 to a6c1edc Compare August 28, 2025 23:14
@Jiralite Jiralite requested a review from Copilot August 28, 2025 23:24
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for select components in Discord modals by introducing a new Label component type and updating the modal component architecture. The changes allow string select components to be used within modals, addressing the limitations of the previous action row-only approach.

Key changes:

  • Introduces a new Label component type that can wrap modal components with descriptive text
  • Adds support for string select components in modals with a required property
  • Deprecates the use of action rows in modals in favor of the new label-based approach

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
payloads/v9/channel.ts Adds Label component type, updates modal component types, and modifies text input to support label wrapping
payloads/v10/channel.ts Same changes as v9 for API version 10 compatibility
payloads/v9/_interactions/responses.ts Updates modal response callback data to support new component types
payloads/v10/_interactions/responses.ts Same response updates as v9 for API version 10
payloads/v9/_interactions/modalSubmit.ts Adds support for string select submission data in modal submit interactions
payloads/v10/_interactions/modalSubmit.ts Same modal submit updates as v9 for API version 10
deno/payloads/v9/channel.ts Deno equivalent of the v9 channel changes
deno/payloads/v9/_interactions/responses.ts Deno equivalent of the v9 response changes
deno/payloads/v9/_interactions/modalSubmit.ts Deno equivalent of the v9 modal submit changes
deno/payloads/v10/channel.ts Deno equivalent of the v10 channel changes
deno/payloads/v10/_interactions/responses.ts Deno equivalent of the v10 response changes
deno/payloads/v10/_interactions/modalSubmit.ts Deno equivalent of the v10 modal submit changes

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were meant to use APISelectMenuComponentInMessage?

@vladfrangu vladfrangu merged commit 3659c59 into main Aug 29, 2025
6 of 7 checks passed
@vladfrangu vladfrangu deleted the feat/select-in-modals branch August 29, 2025 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants