refactor: typescript rewrite #186
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: lintstaged and prettier configs
OfficialSirH
force-pushed
the
ts-rewrite
branch
from
7be34c5 to
65e68bb
Compare
Jiralite
reviewed
Feb 9, 2025
Jiralite
reviewed
Feb 9, 2025
Jiralite
reviewed
Feb 9, 2025
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Qjuh
reviewed
May 1, 2025
| "lint": "prettier --check . && cross-env TIMING=1 eslint --format=pretty src", | ||
| "format": "prettier --write . && cross-env TIMING=1 eslint --fix --format=pretty src", | ||
| "fmt": "pnpm run format", | ||
| "docs": "pnpm run build:docs && api-extractor run --local", |
There was a problem hiding this comment.
How is this supposed to work, when api-extractor isn’t a dev dependency at all?
There was a problem hiding this comment.
I assume that package isn't possible to use until this is merged with the main repo. Could we ignore that until this merged later on to the main repo, or perhaps I just create a new PR for the main repo for this rewrite instead?
There was a problem hiding this comment.
The CI on this repository will try to run that on merge (and fail). So if you'd want to ignore this then you probably should also edit the CI to not run (or delete it completely).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have it generally rewritten, but need to test out a lot of the commands and events to confirm their types and functionality.
List of Events to be tested:
List of RPC Commands to be tested: