Skip to content

Updating #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 241 commits into from
Jul 25, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
241 commits
Select commit Hold shift + click to select a range
3a24c63
Documentation: Fix LayoutWithFlexbox.md broken example
valscion Jul 6, 2016
ba3c7ef
Fix the getRowData method of SwipeableListViewDataSource in Swipeable…
sscaff1 Jul 6, 2016
7795918
Unrevert D3518381
jeffmo Jul 6, 2016
7f790dc
Pull an updated version of fbjni into RN OSS
mhorowitz Jul 6, 2016
d49ea02
update blog with misc minor requests
lacker Jul 6, 2016
c4fc504
Fix the yeoman-environment version
tychota Jul 6, 2016
a7d032b
Display JS exceptions and stacks in a red box
mhorowitz Jul 6, 2016
e209f2f
Move Bridge functions to OSS -- RTL experiment
MengjueW Jul 6, 2016
201433f
Fixed flowconfig for user apps
bestander Jul 7, 2016
10d41b5
Add getType/getPrivate to Value
astreet Jul 7, 2016
f534560
Add JSCHelper function to easily install native hooks outside of JSCE…
astreet Jul 7, 2016
4f5c2b4
Fix timestamps on android touch events to use milliseconds, to be con…
mikelambert Jul 7, 2016
9729926
Refactor RCTPerformanceLogger to avoid having global state
alexeylang Jul 7, 2016
6779d13
Reverted commit D3528215
mikelambert Jul 7, 2016
f11a783
Make packager reconnect less noisy
lexs Jul 7, 2016
af24e80
Add new FileSourceProvider
tadeuzagallo Jul 7, 2016
95401ab
Create tracing name in C++ instead of Java
lexs Jul 7, 2016
be0abd1
Remove a bunch of copies
lexs Jul 7, 2016
2537157
Implement TextInput onContentSizeChange
janicduplessis Jul 7, 2016
b5c3550
Don't hard crash if you get a null stack trace in Android
astreet Jul 7, 2016
eeb9cd8
Better error message when trying to parse a empty body in fetch
astreet Jul 7, 2016
4106499
fix: increased fs timeout for assetserver to test if this helps for l…
bestander Jul 7, 2016
bcf4bb6
Automated changes to remove implicit capture of self in blocks: Libra…
Jul 7, 2016
f51fc36
remove unneeded preserve_paths declaration
janmonschke Jul 7, 2016
5323b77
Expose a way to get the JSContext from a RCTJSCExecutor
adamjernst Jul 7, 2016
b3ac5f0
Close RAM bundle as soon as we read the magic number
adamjernst Jul 7, 2016
77752a0
Move locals closer to point they are used
adamjernst Jul 7, 2016
65120d7
Avoid dispatching to the global queue to read the 4 byte RAM bundle m…
adamjernst Jul 7, 2016
a203cf4
Make addSynchronousHookWithName private
adamjernst Jul 7, 2016
7e1ea48
Make executeAsyncBlockOnJavaScriptQueue required
adamjernst Jul 7, 2016
5e10d3e
Fixed the diagram in the FBPortForwarding README
cornedor Jul 7, 2016
6565edc
Fixing typo
Jul 7, 2016
80c23ae
Reverted commit D3207541
Jul 7, 2016
96b47eb
Inline _addSynchronousHookWithName
adamjernst Jul 7, 2016
dd5bb7b
Pull native hook registration into class method
adamjernst Jul 7, 2016
2b397c5
Redo cookie map for nativeTraceBeginAsyncSection
adamjernst Jul 7, 2016
222060b
Remove needless helper method
adamjernst Jul 7, 2016
46a6851
Use active scene passed in `props` by `NavigationTransitioner`
jmurzy Jul 8, 2016
c3f4d79
changes link file on Android to MainApplication.java for 0.29 update
GantMan Jul 8, 2016
3ddf3db
Fixed objc test runner and bezier test
bestander Jul 8, 2016
89a53b6
Use AT_MOST measurespec when onyl max dimension is defined
Jul 8, 2016
29f9be6
Remove needless weak self in RCTJSCExecutor
adamjernst Jul 8, 2016
1ebd9c5
Create JSContext inside setUp
adamjernst Jul 8, 2016
ca66383
Correctly size cross axis when measuring flex basis
Jul 8, 2016
cadc753
Change NavigatorSceneConfig for RTL
MengjueW Jul 8, 2016
7e5fc17
Provide RTL support for SwipeableRow
MengjueW Jul 8, 2016
7ee2f48
Remove left-over ctx property from RCTJavaScriptContext
adamjernst Jul 8, 2016
294173a
Organize ivars in RCTJSCExecutor
adamjernst Jul 8, 2016
39cb110
Add the ability to pre-create the JavaScript thread with RCTJSCExecutor
adamjernst Jul 8, 2016
2426b3b
Prevent tests with invalid UTF-8 from failing when jest reads them fr…
davidaurelio Jul 8, 2016
dd06b74
Make SoLoader an external dependency
Jul 8, 2016
70b989e
Revert land of css-layout PR #199
Jul 8, 2016
d73446c
Fixed position of ripple-effect
noerK Jul 9, 2016
65ff819
Remove instructions about IP address on iOS
charpeni Jul 9, 2016
c0316c6
Fixed the issue due to which js assets are not bundled in the apk whe…
Jul 10, 2016
4aedcc7
Fix double completion callback in RCTJavascriptLoader
javache Jul 10, 2016
0b773c4
Navigator - making changes so that a simple flick can be detected
Jul 11, 2016
defc34a
Removed calls to RCTBundleURLProvider setDefaults
nathanajah Jul 11, 2016
c8b5880
Renamed updateObject:forKey to updateValue:forKey
nathanajah Jul 11, 2016
a2c6a7b
export SwipeableListView component.
chenxsan Jul 11, 2016
13a19a8
Don't block scroll when using non-touchable visible row for SwipeableRow
chirag04 Jul 11, 2016
e565056
Class for JS stack frames instead of dictionaries
frantic Jul 11, 2016
5d06918
Add new FileSourceProvider
tadeuzagallo Jul 11, 2016
4840233
Bring back FBPortForwarding into fbobjc (Revert D3056293)
Jul 11, 2016
7b718b0
Allow RCTDisplayLink to pause more often
javache Jul 11, 2016
6d3c7b8
Fix 'Unexpected EOF' in old bridge
astreet Jul 11, 2016
ed4db63
RN: Change Time Drift Error into Warning
yungsters Jul 11, 2016
1db7813
RN: Clean JSTimersExecution JS
yungsters Jul 11, 2016
b33424e
Fix links from networking to navigation in The Basics.
hramos Jul 11, 2016
8fb6111
Make loadRAMBundle a C function, not a method
adamjernst Jul 11, 2016
5e89baa
Remove needless weakSelf from executeApplicationScript
adamjernst Jul 11, 2016
af7104b
Extract part of executeApplicationScript into a C function
adamjernst Jul 11, 2016
2ae23d9
Flush pending calls off the main-thread
javache Jul 11, 2016
81f59df
Remove code for testing without JS bundle
javache Jul 11, 2016
3816ced
nil out pendingCalls when we're done with them
javache Jul 11, 2016
ff3ab32
Cleanup RCTImageLoader weakSelf/strongSelf
javache Jul 11, 2016
ba4c34c
Remove deprecated nativeScrollDelegate property
javache Jul 11, 2016
0a98b61
Change how native require hook is registered
adamjernst Jul 11, 2016
9b184cc
Fix bug in cancelling last task in TaskQueue
sahrens Jul 11, 2016
4d6c1e5
Bring back trackingName
sahrens Jul 12, 2016
d905af4
Delete AnimatedNative-test
Jul 12, 2016
471ee87
Wrap native module I18nManager with a new RCTI18nManager.js and fix c…
MengjueW Jul 12, 2016
38a6eec
Provide RTL support for new Navigator -- Make RTL works in NUX
MengjueW Jul 12, 2016
80c71e5
Refine RCTJSCExecutor's APIs for using a thread/context that already …
adamjernst Jul 12, 2016
c7a5906
Expose a method to synchronously load bundle if possible
adamjernst Jul 12, 2016
3be8c95
Minor cleanup to make loader unaware of bridge
adamjernst Jul 12, 2016
7b7ecdf
Cleanup warnings
javache Jul 12, 2016
2f73ca8
Cleanup UIExplorer folder
javache Jul 12, 2016
e632025
Allow apps to provide JSBundleLoader of their choice
Jul 12, 2016
a665914
Unpack files required by optimized bundle format
Jul 12, 2016
1331e20
add API to CatalystInstanceImpl for executing optimized bundle
Jul 12, 2016
0d3c4f8
Temporarily enable ReactHorizontalScrollViewTestCase to run in SandCa…
bestander Jul 12, 2016
c33084c
Read within bounds of `NSData` object
davidaurelio Jul 12, 2016
cb31d4c
Use tabIndex instead of tabindex
JoelMarcey Jul 12, 2016
3a53228
Prevent race condition on immediate transition
wsun Jul 12, 2016
a74780e
Fix favicon location error
JoelMarcey Jul 12, 2016
f317b9f
Fix misusage of NSUInteger * in RCTImageStoreManager
jesseluo Jul 12, 2016
5189c94
Fix Navigator transition.
Jul 13, 2016
b06b7ae
Fix Relay tests, fix React.js whitespace
cpojer Jul 13, 2016
33a1f28
Android WebView “tel:” links show web page not found - issue fixed
sathyapriya-31 Jul 13, 2016
58202b7
expose remote/local flag from native side instead of JS side
Jul 13, 2016
afbd2d7
Added FanVision Bolt to showcase
jeanregisser Jul 13, 2016
68b0ce6
iOS: Provide correct initial value for AppState.currentState
Jul 13, 2016
c06a136
Fix broken link to PanResponderExample.js
anttimo Jul 13, 2016
262397d
Fix UIExplorer example AppDelegate.m for pre-bundle comment
Jul 13, 2016
91ff686
Use HTTP range requests (responses) to serve mp4 from assets
mroswald Jul 13, 2016
c65eb4e
open in editor button for yellow box
skv-headless Jul 13, 2016
08c375f
Add responseType as a concept to RCTNetworking, send binary data as b…
philikon Jul 13, 2016
8baaad9
Fixed mispell in doc Actvity -> Activity
Nepherhotep Jul 13, 2016
ceffb08
Remove more weakSelf/strongSelf errors
javache Jul 13, 2016
f15031a
Fix path to UIExplorer examples
javache Jul 13, 2016
3b4120d
Simplify JS error to NSError API
adamjernst Jul 13, 2016
86e304f
Move csslayout into xplat
Jul 13, 2016
70e97f9
Fix broken links in the documentation
Jul 13, 2016
38157f0
Fix UIExplorer List
Jul 13, 2016
8dd8c41
Point csslayout deps over to xplat
Jul 13, 2016
8612d76
Add WebView.dataDetectorTypes prop.
Jul 13, 2016
b1e4983
Make prev links work in guides and APIs.
JoelMarcey Jul 13, 2016
c89c25f
Make new bridge default in OSS
cjhopman Jul 13, 2016
e8a388a
Fix broken link in docs
AndrewKe Jul 13, 2016
90c2605
Change TextInput prop check to print instead of throw
dozoisch Jul 13, 2016
37d0339
Improve error message for non-file URLs
adamjernst Jul 13, 2016
235dd00
Remove allowLoadingNonRAMBundles
adamjernst Jul 13, 2016
b4e267a
Refactor RCTBundleURLProvider
adamjernst Jul 13, 2016
16d29fe
Minor refactor to RCTBundleURLProvider's constants
adamjernst Jul 13, 2016
22eabe5
Introduce experimental API to allow overriding how packager run statu…
adamjernst Jul 13, 2016
18394fb
Initial implementation of requestIdleCallback on Android
janicduplessis Jul 14, 2016
5618c3f
Initial implementation of requestIdleCallback on iOS
janicduplessis Jul 14, 2016
70ac81f
Update Touchable docs with new image require syntax
Jul 14, 2016
8d24cb4
Update deprecated comment in PushNotificationIOS
Jul 14, 2016
b9f391d
Avoid wrapping every UIManager block in another block
javache Jul 14, 2016
d46163a
fbkpm.lock file is not synced to OSS anymore
bestander Jul 14, 2016
eb7442b
Opt in to use fetch from node_modules
bestander Jul 14, 2016
f5ba169
Allow getters and setters in flow check
deminoth Jul 14, 2016
9bfa393
fix new flow errors after D3561327
davidaurelio Jul 14, 2016
a939f31
Name library header same as library
Jul 14, 2016
f22e86e
Changed vendored folder name to match library name
Jul 14, 2016
94efa8f
Adapt unit tests
davidaurelio Jul 14, 2016
55fb4f4
Don't close WebSocket if it fails during connect
lexs Jul 14, 2016
23e087f
Fix TextInput stack overflow when pasting text in multiline input wit…
javache Jul 14, 2016
e9f53ee
Remove CSSLayoutTestUtils from RN
Jul 14, 2016
7d2b571
async/await is not part of ES7
Jul 14, 2016
df01215
Reverted commit D3545345
davidaurelio Jul 14, 2016
03a2f61
Fixed what fetch.js exports
bestander Jul 14, 2016
b0c023c
fix removing views from ViewPagerAndroid
foghina Jul 14, 2016
0c0ac6e
Support RefreshControl in RecyclerViewBackedScrollView in Android
tegon Jul 14, 2016
3c0f428
Fix optimized bundle stuff.
Jul 14, 2016
ca0d702
Fix link broken.
Jul 14, 2016
2b1b841
update the showcase instructions to be more specific
lacker Jul 15, 2016
81bf5de
Add more autogenerated documentation to the whitelist
lacker Jul 15, 2016
52b4ae1
Pull requests should target master branch
JoelMarcey Jul 15, 2016
f38d9a1
Fix description of AlertIOS.prompt()'s parameter defaultValue.
Jul 15, 2016
4e056e9
Use library imports for csslayout
Jul 15, 2016
31f01c0
Eliminate "packager running predicate"
adamjernst Jul 15, 2016
ff0eb47
Adapt jest transform for node-only files
davidaurelio Jul 15, 2016
0b6f0fc
Correctly specify run_tests for all apps in ci_config
javache Jul 15, 2016
f2d83a2
update AsyncStorage.js documentation
arielelkin Jul 15, 2016
f4d614a
fix broken link
sunnylqm Jul 15, 2016
8712438
Changed JS location of examples to source from RCTBundleURLProvider i…
nathanajah Jul 15, 2016
6eb318d
update flow to v0.29.0
bestander Jul 15, 2016
4843a90
PanResponder should not hold stale handle for interaction.
Jul 15, 2016
edb9fce
#6 Notify SamplingProfiler of the main MachineThread
lukaspiatkowski Jul 15, 2016
f067811
Small typo s/they/the/
denmark Jul 15, 2016
80872ff
Remove exported constants from RCTTimers to allow lazy initialization
janicduplessis Jul 15, 2016
7aeaf7d
Updated React to 15.2.1
bestander Jul 15, 2016
9e142a1
Provide RTL support for RCTShadowText
MengjueW Jul 16, 2016
3c8a2ee
Fix native modules linking in 0.29.1
Jul 16, 2016
abe9f51
Fix documentation link in README.md
awinograd Jul 17, 2016
df8c88e
Fix UIExplorer entry file on iOS
janicduplessis Jul 17, 2016
ca5d1ae
Defend against nil pointer in RCTImageLoader.m
Jul 18, 2016
7fa677f
Add MessageQueue method for executing function and returning its result
javache Jul 18, 2016
23e28ec
Add completion callback to enqueueJSCall
javache Jul 18, 2016
4269003
Make bridge initialization configurable
javache Jul 18, 2016
750da65
Update suppress_comment for v0.29.0
gabelevi Jul 18, 2016
5f62379
Update IntegrationWithExistingApps.md
Gab-Metzger Jul 18, 2016
8333613
Fix minor typo in ListViewExample.js
eronisko Jul 18, 2016
9d2e6a2
Add ability to customize error messages and stacks within the iOS redbox
Jul 18, 2016
40c06b9
Short-circuit setContentInset in RCTScrollView
Jul 18, 2016
e27c149
network congestion improvements (part 1)
olinotteghem Jul 18, 2016
4ccd14f
Integrating AutoUpdater's custom JS Bundle loading into Fb4a
Jul 18, 2016
a564af8
Throw flow error when trying to access a style that is not defined on…
brentvatne Jul 19, 2016
fa062aa
fix UIExplorer build path
takeru Jul 19, 2016
36ee027
Add debugging with Stetho instructions #934
rakannimer Jul 19, 2016
d343eaa
Added the native animation demo to the android UIExplorer
Jul 19, 2016
bee1180
Add Image resizeMode center to iOS
aleclarson Jul 19, 2016
25ed41c
update yeoman-generator to 0.21 because of RegExp DoS issue
hollanderbart Jul 19, 2016
875d5d2
update doc for android MainApplication.java
wasabia Jul 19, 2016
46417dd
Get server host in setupDevtools for Android
jhen0409 Jul 19, 2016
63e0e6c
Add more profiling markers to RCTJSCExecutor
javache Jul 19, 2016
6d12770
Show the right error message in the console
newmetl Jul 19, 2016
a527ef2
Fix Popover problem for RTL 1/n
MengjueW Jul 19, 2016
702c14b
Enabled Vertical ScrollView instrumentation test in SandCastle
bestander Jul 20, 2016
1025775
Remove fillCSSNode method
Jul 20, 2016
0587c85
Add [RCTShadowView isCSSLeaf] for skipping css tree of children
Jul 20, 2016
e1b3bbd
Android: Refactor HierarchyOptimizer in preparation of inline view su…
Jul 20, 2016
654e4be
Better folly::dynamic ==> JSValue conversion
dcaspi Jul 20, 2016
b7bf24b
Support geolocation in android webview
jvassbo Jul 20, 2016
1aa7ad0
CamelCase
Jul 20, 2016
c47f745
Update OkHttp to 3.4.0 and Okio to 1.9.0
AndrewJack Jul 20, 2016
c4ffc7d
Android: Fix handling of line height with inline images
Jul 20, 2016
b25005a
AdsManager now uses new react native QPL identifiers
cwdick Jul 20, 2016
768caf5
Use library style import for CSSMacros
Jul 20, 2016
12ec213
Add support for layout gravity to ToastAndroid
donyu Jul 20, 2016
1af9270
Revamp API
Jul 20, 2016
c7ff46b
Make isTextNode a prop instead of a function
Jul 20, 2016
0ab1486
Provide I18n Module in OSS 1/3
MengjueW Jul 20, 2016
566e055
Provide I18n Module in OSS 2/3
MengjueW Jul 20, 2016
0df569d
Handle children internally in CSSLayout
Jul 20, 2016
700e82f
Provide I18n Module in OSS 3/3
MengjueW Jul 20, 2016
faabead
Fix JSX string props quote convention
fadils Jul 21, 2016
da063e3
Set Event timestamp internally
Jul 21, 2016
7e5de70
Remove deprecated RCTImageLoader methods
javache Jul 21, 2016
5903949
Load local assets synchronously to prevent image flicker
janicduplessis Jul 21, 2016
631785f
Change RCTImageLoader's Cache System to default NSURLRequest's cache …
namse Jul 21, 2016
b857631
Fix BackAndroid subscriptions calls
SergeyKorochansky Jul 21, 2016
5db5ee9
Upgrade to React v15.3.0-rc.2
zpao Jul 21, 2016
20f48de
Fix broken links in Handling Touches documentation
charpeni Jul 21, 2016
e7fba4c
Remove some throw specifications
cjhopman Jul 22, 2016
a07026d
Put setChildren debug log in DEBUG clause
astreet Jul 22, 2016
235c059
Support API "scrollTo" in RecyclerViewBackedScrollView on Android
Jul 22, 2016
37e5f3b
fix mTimerIdsToTimers remove error
ASCE1885 Jul 22, 2016
09fff49
Remove redundant destructuring
Corei13 Jul 22, 2016
82c8129
Fix double React perflogger creation
javache Jul 22, 2016
0e65456
plumb trackingName through to native requests
swolchok Jul 22, 2016
55638f8
Move dirty layout into css-layout
Jul 22, 2016
32a7178
safeguard for missing ImageLoader native module
olinotteghem Jul 22, 2016
5f41769
Fix ViewPager behavior with Nodes
Jul 22, 2016
eb59ae8
Set trackingName for RCTImageLoader requests
swolchok Jul 22, 2016
64b0929
Reverted commit D3604593
bestander Jul 23, 2016
15dfa5b
Reverted commit D3598946
Jul 23, 2016
143b649
Add AppRegistry to imports in example
greyvugrin Jul 23, 2016
feb2825
A fix for npmlog error
GevaZeichner Jul 25, 2016
c21d3a1
fix NullPointerException Caused by manageChildren
ASCE1885 Jul 25, 2016
3b35732
Add Share module
deminoth Jul 25, 2016
471eefc
Move dirty layout into css-layout
Jul 25, 2016
d15d6d7
Update NavigatorIOS.ios.js
stevenchung Jul 25, 2016
d06bea4
Add dep for android local unit tests
deminoth Jul 25, 2016
1234d27
Uniformize links in LayoutPropTypes docs
Jul 25, 2016
c658cc5
Fix navigation card stack pan responder
ahanriat Jul 25, 2016
d67258e
Move some really old tests to the cxx bridge
cjhopman Jul 25, 2016
857d2b8
change lineBreakMode to ellipsizeMode
skv-headless Jul 25, 2016
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 2 additions & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"__fbBatchedBridgeConfig": false,
"alert": false,
"cancelAnimationFrame": false,
"cancelIdleCallback": false,
"clearImmediate": true,
"clearInterval": false,
"clearTimeout": false,
Expand All @@ -40,6 +41,7 @@
"process": false,
"Promise": true,
"requestAnimationFrame": true,
"requestIdleCallback": true,
"require": false,
"Set": true,
"setImmediate": true,
Expand Down
23 changes: 20 additions & 3 deletions .flowconfig
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,21 @@
# Ignore malformed json
.*/node_modules/y18n/test/.*\.json

# Ignore the website subdir
<PROJECT_ROOT>/website/.*

# Ignore BUCK generated dirs
<PROJECT_ROOT>/\.buckd/

# Ignore unexpected extra @providesModule
.*/node_modules/commoner/test/source/widget/share.js

# Ignore duplicate module providers
# For RN Apps installed via npm, "Libraries" folder is inside node_modules/react-native but in the source repo it is in the root
.*/Libraries/react-native/React.js
.*/Libraries/react-native/ReactNative.js
.*/node_modules/jest-runtime/build/__tests__/.*

[include]

[libs]
Expand All @@ -32,9 +47,11 @@ suppress_type=$FlowIssue
suppress_type=$FlowFixMe
suppress_type=$FixMe

suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-7]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(2[0-7]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(2[0-9]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(2[0-9]\\|1[0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy

unsafe.enable_getters_and_setters=true

[version]
^0.27.0
^0.29.0
2 changes: 2 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request:

> **Unless you are a React Native release maintainer and cherry-picking an *existing* commit into a current release, ensure your pull request is targeting the `master` React Native branch.**

(You can skip this if you're fixing a typo or adding an app to the Showcase.)

Explain the **motivation** for making this change. What existing problem does the pull request solve?
Expand Down
4 changes: 2 additions & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ We will do our best to keep `master` in good shape, with tests passing at all ti

The core team will be monitoring for pull requests. When we get one, we'll run some Facebook-specific integration tests on it first. From here, we'll need to get another person to sign off on the changes and then merge the pull request. For API changes we may need to fix internal uses, which could cause some delay. We'll do our best to provide updates and feedback throughout the process.

Please submit your pull request on the *master* branch. If the fix is critical and should be included in a stable branch please mention it and it will be cherry picked into it.
**Please submit your pull request on the `master` branch**. If the fix is critical and should be included in a stable branch please mention it and it will be cherry picked into it.

*Before* submitting a pull request, please make sure the following is done…

Expand Down Expand Up @@ -101,7 +101,7 @@ Facebook has a [bounty program](https://www.facebook.com/whitehat/) for the safe

#### JSX

* Prefer `'` over `"` for string literal props
* Prefer `"` over `'` for string literal props
* When wrapping opening tags over multiple lines, place one prop per line
* `{}` of props should hug their values (no spaces)
* Place the closing `>` of opening tags on the same line as the last prop
Expand Down
18 changes: 18 additions & 0 deletions Examples/2048/2048.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,7 @@
13B07F871A680F5B00A75B9A /* Sources */,
13B07F8C1A680F5B00A75B9A /* Frameworks */,
13B07F8E1A680F5B00A75B9A /* Resources */,
68ACCCD51D2BE2D2008E368A /* Run Script */,
);
buildRules = (
);
Expand Down Expand Up @@ -230,6 +231,23 @@
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXShellScriptBuildPhase section */
68ACCCD51D2BE2D2008E368A /* Run Script */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
name = "Run Script";
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "export NODE_BINARY=node\n$SRCROOT/../../packager/react-native-xcode.sh Examples/2048/Game2048.js\n";
};
/* End PBXShellScriptBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
13B07F871A680F5B00A75B9A /* Sources */ = {
isa = PBXSourcesBuildPhase;
Expand Down
31 changes: 2 additions & 29 deletions Examples/2048/2048/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,41 +14,14 @@

#import "AppDelegate.h"

#import "RCTBundleURLProvider.h"
#import "RCTRootView.h"

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
NSURL *jsCodeLocation;

/**
* Loading JavaScript code - uncomment the one you want.
*
* OPTION 1
* Load from development server. Start the server from the repository root:
*
* $ npm start
*
* To run on device, change `localhost` to the IP address of your computer
* (you can get this by typing `ifconfig` into the terminal and selecting the
* `inet` value under `en0:`) and make sure your computer and iOS device are
* on the same Wi-Fi network.
*/

jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/Examples/2048/Game2048.bundle?platform=ios&dev=true"];

/**
* OPTION 2
* Load from pre-bundled file on disk. To re-generate the static bundle, `cd`
* to your Xcode project folder in the terminal, and run
*
* $ curl 'http://localhost:8081/Examples/2048/Game2048.bundle?platform=ios' -o main.jsbundle
*
* then add the `main.jsbundle` file to your project and uncomment this line:
*/

// jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
NSURL *jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"Examples/2048/Game2048" fallbackResource:nil];

RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"Game2048"
Expand Down
17 changes: 17 additions & 0 deletions Examples/Movies/Movies.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -200,6 +200,7 @@
13B07F871A680F5B00A75B9A /* Sources */,
13B07F8C1A680F5B00A75B9A /* Frameworks */,
13B07F8E1A680F5B00A75B9A /* Resources */,
68ACCCEE1D2BE57F008E368A /* ShellScript */,
);
buildRules = (
);
Expand Down Expand Up @@ -320,6 +321,22 @@
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXShellScriptBuildPhase section */
68ACCCEE1D2BE57F008E368A /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "export NODE_BINARY=node\n$SRCROOT/../../packager/react-native-xcode.sh Examples/Movies/MoviesApp.ios.js\n";
};
/* End PBXShellScriptBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
13B07F871A680F5B00A75B9A /* Sources */ = {
isa = PBXSourcesBuildPhase;
Expand Down
31 changes: 2 additions & 29 deletions Examples/Movies/Movies/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,42 +14,15 @@

#import "AppDelegate.h"

#import "RCTBundleURLProvider.h"
#import "RCTLinkingManager.h"
#import "RCTRootView.h"

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
NSURL *jsCodeLocation;

/**
* Loading JavaScript code - uncomment the one you want.
*
* OPTION 1
* Load from development server. Start the server from the repository root:
*
* $ npm start
*
* To run on device, change `localhost` to the IP address of your computer
* (you can get this by typing `ifconfig` into the terminal and selecting the
* `inet` value under `en0:`) and make sure your computer and iOS device are
* on the same Wi-Fi network.
*/

jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/Examples/Movies/MoviesApp.ios.bundle?platform=ios&dev=true"];

/**
* OPTION 2
* Load from pre-bundled file on disk. To re-generate the static bundle, `cd`
* to your Xcode project folder in the terminal, and run
*
* $ curl 'http://localhost:8081/Examples/Movies/MoviesApp.ios.bundle?platform=ios&dev=true' -o main.jsbundle
*
* then add the `main.jsbundle` file to your project and uncomment this line:
*/

// jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
NSURL *jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"Examples/Movies/MoviesApp.ios" fallbackResource:nil];

RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"MoviesApp"
Expand Down
17 changes: 17 additions & 0 deletions Examples/TicTacToe/TicTacToe.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,7 @@
13B07F871A680F5B00A75B9A /* Sources */,
13B07F8C1A680F5B00A75B9A /* Frameworks */,
13B07F8E1A680F5B00A75B9A /* Resources */,
681C70ED1D2BE73C00E71791 /* ShellScript */,
);
buildRules = (
);
Expand Down Expand Up @@ -290,6 +291,22 @@
};
/* End PBXResourcesBuildPhase section */

/* Begin PBXShellScriptBuildPhase section */
681C70ED1D2BE73C00E71791 /* ShellScript */ = {
isa = PBXShellScriptBuildPhase;
buildActionMask = 2147483647;
files = (
);
inputPaths = (
);
outputPaths = (
);
runOnlyForDeploymentPostprocessing = 0;
shellPath = /bin/sh;
shellScript = "export NODE_BINARY=node\n$SRCROOT/../../packager/react-native-xcode.sh Examples/TicTacToe/TicTacToeApp.js\n";
};
/* End PBXShellScriptBuildPhase section */

/* Begin PBXSourcesBuildPhase section */
13B07F871A680F5B00A75B9A /* Sources */ = {
isa = PBXSourcesBuildPhase;
Expand Down
31 changes: 2 additions & 29 deletions Examples/TicTacToe/TicTacToe/AppDelegate.m
Original file line number Diff line number Diff line change
Expand Up @@ -14,41 +14,14 @@

#import "AppDelegate.h"

#import "RCTBundleURLProvider.h"
#import "RCTRootView.h"

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
NSURL *jsCodeLocation;

/**
* Loading JavaScript code - uncomment the one you want.
*
* OPTION 1
* Load from development server. Start the server from the repository root:
*
* $ npm start
*
* To run on device, change `localhost` to the IP address of your computer
* (you can get this by typing `ifconfig` into the terminal and selecting the
* `inet` value under `en0:`) and make sure your computer and iOS device are
* on the same Wi-Fi network.
*/

jsCodeLocation = [NSURL URLWithString:@"http://localhost:8081/Examples/TicTacToe/TicTacToeApp.bundle?platform=ios&dev=true"];

/**
* OPTION 2
* Load from pre-bundled file on disk. To re-generate the static bundle, `cd`
* to your Xcode project folder in the terminal, and run
*
* $ curl 'http://localhost:8081/Examples/TicTacToe/TicTacToeApp.bundle?platform=ios' -o main.jsbundle
*
* then add the `main.jsbundle` file to your project and uncomment this line:
*/

// jsCodeLocation = [[NSBundle mainBundle] URLForResource:@"main" withExtension:@"jsbundle"];
NSURL *jsCodeLocation = [[RCTBundleURLProvider sharedSettings] jsBundleURLForBundleRoot:@"Examples/TicTacToe/TicTacToeApp" fallbackResource:nil];

RCTRootView *rootView = [[RCTRootView alloc] initWithBundleURL:jsCodeLocation
moduleName:@"TicTacToeApp"
Expand Down
Loading