Skip to content

misc: Bump ffmpeg #231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 26, 2025
Merged

misc: Bump ffmpeg #231

merged 7 commits into from
Mar 26, 2025

Conversation

salarkhan
Copy link
Contributor

Summary

ffmpeg is a couple major versions behind. this PR bumps it to current stable and makes corresponding code changes to ensure tests are still passing and we're still happy.

@salarkhan salarkhan force-pushed the salar/bump-ffmpeg branch 2 times, most recently from d6d357f to eed23a6 Compare March 24, 2025 19:23
@salarkhan salarkhan marked this pull request as ready for review March 25, 2025 18:08
@salarkhan salarkhan force-pushed the salar/bump-ffmpeg branch 2 times, most recently from 0b298ed to da7a6e4 Compare March 26, 2025 15:02
Copy link
Contributor

@remiolivier-discord remiolivier-discord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

- guard pre-ffmpeg install
- null check for codec ctx cancellation
- clean up the avio context
- flush & free the buffer, then free the ctx
- prevent use-after-free issues
from ffmpeg changelog:
2023-10-06 - 5432d2aacad - lavc 60.15.100 - avformat.h
Deprecate AVFormatContext.{nb_,}side_data, av_stream_add_side_data(),
av_stream_new_side_data(), and av_stream_get_side_data(). Side data fields
from AVFormatContext.codecpar should be used from now on.
@salarkhan salarkhan merged commit 2ac3386 into master Mar 26, 2025
5 checks passed
@salarkhan salarkhan deleted the salar/bump-ffmpeg branch March 26, 2025 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants