Conversation
advaith1
approved these changes
Jul 10, 2025
Comment on lines
170
to
+175
| large_image: zod.string().nullable(), | ||
| large_text: zod.string().nullable(), | ||
| large_url: zod.string().url().optional().nullable(), | ||
| small_image: zod.string().nullable(), | ||
| small_text: zod.string().nullable(), | ||
| small_url: zod.string().url().optional().nullable(), |
Contributor
There was a problem hiding this comment.
unsure if we want only the _url fields to be optional but idk why some fields are only nullable and some fields are optional + nullable in the existing code.
Contributor
Author
There was a problem hiding this comment.
i did optional + nullable to align with what details and state had -- i imagine the reason why large/small_image/text are nullable but not optional is that the intention is if (assets) { images & text should be defined }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as part of a change that just went out today, we now support new fields for rich presence activities:
state_url- URL that is linked to when clicking on the state text in the activity carddetails_url- URL that is linked to when clicking on the details text in the activity cardassets.large_url- URL that is linked to when clicking on the large image in the activity cardassets.small_url- URL that is linked to when clicking on the small image in the activity cardthis PR adds support for those fields to the embedded app sdk
there is a docs pr to update documentation here: discord/discord-api-docs#7674