chore: migrate to npm #247
Merged
+11,456
−6,309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthova
reviewed
Aug 28, 2024
Comment on lines
+37
to
+38
| // Also remove the .npm prefix if present | ||
| .replace('.npm/', ''); |
There was a problem hiding this comment.
we may not need this, but 🤷🏻 if it doesn't break anything
There was a problem hiding this comment.
Yeah I wasn't entirely sure what that was going to do 😆
matthova
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the samples now living elsewhere, there's really no good reason to keep using
pnpm. I don't feel strongly about this, but moving back to a standard toolchain may be nice.