fix: return UNKNOWN_VERSION_NUMBER when cannot parse

src/Constants.ts

@@ -37,4 +37,5 @@ export const Permissions = Object.freeze({
   ADMINISTRATOR: BigFlagUtils.getFlag(3),
 });
 
+export const UNKNOWN_VERSION_NUMBER = -1;
 export const HANDSHAKE_SDK_VERSION_MINIUM_MOBILE_VERSION = 250;

src/Discord.ts

@@ -6,7 +6,12 @@ import commands, {Commands} from './commands';
 import {v4 as uuidv4} from 'uuid';
 import {SDKError} from './error';
 import {EventSchema, ERROR, Events as RPCEvents} from './schema/events';
-import {Platform, RPCCloseCodes, HANDSHAKE_SDK_VERSION_MINIUM_MOBILE_VERSION} from './Constants';
+import {
+  Platform,
+  RPCCloseCodes,
+  HANDSHAKE_SDK_VERSION_MINIUM_MOBILE_VERSION,
+  UNKNOWN_VERSION_NUMBER,
+} from './Constants';
 import getDefaultSdkConfiguration from './utils/getDefaultSdkConfiguration';
 import {ConsoleLevel, consoleLevels, wrapConsoleMethod} from './utils/console';
 import type {TSendCommand, TSendCommandPayload} from './schema/types';
@@ -208,15 +213,15 @@ export class DiscordSDK implements IDiscordSDK {
     }
   }
 
-  private parseMajorMobileVersion(): number | null {
+  private parseMajorMobileVersion(): number {
     if (this.mobileAppVersion && this.mobileAppVersion.includes('.')) {
       try {
         return parseInt(this.mobileAppVersion.split('.')[0]);
       } catch {
-        return null;
+        return UNKNOWN_VERSION_NUMBER;
       }
     }
-    return null;
+    return UNKNOWN_VERSION_NUMBER;
   }
 
   private handshake() {
@@ -227,10 +232,7 @@ export class DiscordSDK implements IDiscordSDK {
       frame_id: this.frameId,
     };
     const majorMobileVersion = this.parseMajorMobileVersion();
-    if (
-      this.platform === Platform.DESKTOP ||
-      (majorMobileVersion != null && majorMobileVersion >= HANDSHAKE_SDK_VERSION_MINIUM_MOBILE_VERSION)
-    ) {
+    if (this.platform === Platform.DESKTOP || majorMobileVersion >= HANDSHAKE_SDK_VERSION_MINIUM_MOBILE_VERSION) {
       handshakePayload['sdk_version'] = this.sdkVersion;
     }
     this.source?.postMessage([Opcodes.HANDSHAKE, handshakePayload], this.sourceOrigin);