Skip to content

Remove default command contexts sentence #7583

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 30, 2025

Conversation

lsdimagine
Copy link
Contributor

contexts is required if we want the command available outside guild.

@lsdimagine lsdimagine requested a review from a team as a code owner May 30, 2025 21:55
@lsdimagine lsdimagine requested review from colinloretz and yonilerner and removed request for a team May 30, 2025 21:55
@advaith1
Copy link
Contributor

advaith1 commented May 30, 2025

This is also present in the command object table:

Interaction context(s) where the command can be used, only for globally-scoped commands. By default, all interaction context types included for new commands.

However I would prefer that the actual behavior be changed/fixed to reflect the documentation, not the other way around

@lsdimagine
Copy link
Contributor Author

This is also present in the command object table:

Interaction context(s) where the command can be used, only for globally-scoped commands. By default, all interaction context types included for new commands.

However I would prefer that the actual behavior be changed/fixed to reflect the documentation, not the other way around

huh I think currently we have to specify contexts?

@advaith1
Copy link
Contributor

advaith1 commented May 30, 2025

No it's currently optional and has a default value which seems to be GUILD and BOT_DM but not PRIVATE_CHANNEL. ideally it would include all 3 by default, which is what it's supposed to do according to the prev docs

@yonilerner
Copy link
Member

I think theres a bug in the way we handle default dm_permission field thats causing the current behavior. I dont have time rn to open that can of worms though :/ Im concerned behind this simple change is a breaking change to dm_permission

@lsdimagine lsdimagine merged commit b930084 into main May 30, 2025
4 checks passed
@lsdimagine lsdimagine deleted the lsdimagine/remove_default_command_contexts_sentence branch May 30, 2025 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants