Ask to Join Documentation + Cleanup of Existing #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
night
reviewed
Oct 12, 2017
docs/topics/Rich_Presence.md
Outdated
|
|
||
| ## Your New Developer Dashboard | ||
|
|
||
| Included with the launch of Rich Presence is an overhaul of Discord's Developer Dashboard. We want to make Rich Presence and the rest of the GameBridge Suite as easy as possible to use. Our first step is helping you ditch your CDN. You're welcome. | ||
|
|
||
| OK, well, not entirely. But! Discord _will_ host any and all artwork that you need to have the very richest of presences. Upload an image, tag it with a key—preferrably one you can remember—and **bam**. It's ready for Rich Presence use. Head over to your [applications page](#MY_APPLICATIONS/top) to check it out! | ||
|
|
||
| ## It's always better when we're together | ||
| >warn | ||
| >Asset keys are automatically stored as **all lowercase** strings. Be mindful of this when referring to them in your code. |
night
reviewed
Oct 12, 2017
docs/topics/Rich_Presence.md
Outdated
|
|
||
| #### How good is your security? | ||
| To enable the Ask to Join button on your players' profiles, you'll need to be whitelisted by us—send an email to [gamedevs@discordapp.com](mailto:gamedevs@discordapp.com) to request access. Once whitelisted, you'll have access to the `joinRequest()` callback which sends the following data: |
There was a problem hiding this comment.
this should be below the next heading
also pls make this an info/warn callout
There was a problem hiding this comment.
also they dont need a whitelist to get access to the callback.. they just need a whitelist for the button to even show/work in our client
night
reviewed
Oct 12, 2017
docs/topics/Rich_Presence.md
Outdated
|
|
||
| unsigned char* myMessage = "a super secret message for Discord"; | ||
| printf("Original text: %s \n \n", myMessage); | ||
| When it fires, your game should surface this data with a Yes or No choice for the player to accept whether or not they wish to play with the other user. If no, return false. If yes, return true and the `userId` from the request. |
night
reviewed
Oct 12, 2017
docs/topics/Rich_Presence.md
Outdated
| | largeImageText | x | | | | | | ||
| | smallImageText | x | | | | | | ||
| | partyId | | | | x | x | | ||
| | partySize | | | | | | |
There was a problem hiding this comment.
party size + max is still required atm for join stuff
night
approved these changes
Oct 12, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ended up refactoring a bunch of stuff that I didn't think was necessary. Mainly this includes the example secret hashing section. If there is strong feelings, I can add it back in, but I rarely saw it referenced or implemented and it felt a bit like bloat when trying to get to the actual information.
Overall, I went with a more to-the-point approach in the hopes of making it easier to read and find what you're looking for.