Skip to content

Conversation

@advaith1
Copy link
Contributor

@advaith1 advaith1 commented Jun 25, 2020

  • discovery_splash
  • features
  • description

@advaith1 advaith1 changed the title Document modifying guild features and description Document missing fields in Modify Guild Jul 7, 2020
@SinisterRectus
Copy link
Contributor

features can be patched?

@Taarek
Copy link
Contributor

Taarek commented Sep 9, 2020

features can be patched?

yeah, even the desktop client includes this when modifying the guild, nothing happens though if you try to set features you don't have.

@SinisterRectus
Copy link
Contributor

Is it necessary to document if it doesn't do anything? Or if it's documented, should that be explained?

@Taarek
Copy link
Contributor

Taarek commented Sep 9, 2020

Yeah.. I don't think features needs to be documented under modify guild, it's already under https://discord.com/developers/docs/resources/guild#guild-object-guild-structure

@advaith1
Copy link
Contributor Author

advaith1 commented Sep 9, 2020

it's used for enabling community

@SinisterRectus
Copy link
Contributor

Then which features are patchable should be documented, similar to how message flags are documented.

@advaith1 advaith1 changed the title Document missing fields in Modify Guild Document missing fields in Create and Modify Guild Nov 23, 2020
@night night merged commit 5b63dae into discord:master Apr 6, 2021
@advaith1 advaith1 deleted the modify-desc-features branch April 6, 2021 02:28
Nihlus added a commit to Remora/Remora.Discord that referenced this pull request Apr 10, 2021
itohatweb added a commit to discordeno/discordeno that referenced this pull request Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants