Skip to content

Proposal: Make bidirectional formatting optional #2204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 4, 2022

Conversation

csmir
Copy link
Collaborator

@csmir csmir commented Mar 21, 2022

This PR will attempt to not introduce a major change, while making it optional for users to have the user's .ToString() method formatted as "?Rozen?#4334" or "Rozen#4334". By default the behavior will remain the same as it is right now.

This value will be configurable through DiscordConfig.FormatUsersInBidirectionalUnicode. If users may want old behavior, this can be set to false.

@csmir csmir requested a review from quinchs March 21, 2022 18:49
@quinchs quinchs merged commit e38104b into discord-net:dev Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants