feat: client generation #103
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
4 tasks
we only handle json. users can handle other content types with custom response handlers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not tested enough, but I'm throwing the idea out there.
This is WIP, and uses an external package for building requests.
We could technically copy over the external code, or generate it alongside the client, but I thought relying on a battle tested library was worth it, even though it makes for an extra dependency.
The generated code is decent. The only thing I'm unhappy about is how API errors don't get coalesced into an
error, because we would have to figure out what errors are (500s+ only?).We could also pattern match on (
$error^i). It's still decent to work with though.