Add environment variable for using a custom CA (for the additional-certificates configMap to work) #174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The current commented-out additionalVolumes example that loads in a configMap for supplying a custom enterprise root CA doesn't work on its own - we need to tell node to use it via a custom environment variable.
Benefits
Using a custom CA works fully with this.
Possible drawbacks
N/A - we already have commented-out code for custom roots in the values.yaml default from Helm from this chart.
Applicable issues
N/A
Additional information
N/A
Checklist
Chart.yamlaccording to semver.