Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] adds fabric support #958

Merged
merged 2 commits into from
Sep 29, 2024
Merged

[main] adds fabric support #958

merged 2 commits into from
Sep 29, 2024

Conversation

Mx772
Copy link
Contributor

@Mx772 Mx772 commented Jun 20, 2024

Please reference the issue this PR is fixing.
#957

Tested:
image

# TYPE minecraft_dimension_ticktime_total counter
minecraft_dimension_ticktime_total{dimension="black_bridge",namespace="minecells"} 0.009
minecraft_dimension_ticktime_total{dimension="earth_orbit",namespace="ad_astra"} 0.009
minecraft_dimension_ticktime_total{dimension="glacio",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="glacio_orbit",namespace="ad_astra"} 0.009
minecraft_dimension_ticktime_total{dimension="glassocean",namespace="spellbladenext"} 0.01
minecraft_dimension_ticktime_total{dimension="insufferable_crypt",namespace="minecells"} 0.009
minecraft_dimension_ticktime_total{dimension="mars",namespace="ad_astra"} 0.009
minecraft_dimension_ticktime_total{dimension="mars_orbit",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="mercury",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="mercury_orbit",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="moon",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="moon_orbit",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="otherside",namespace="deeperdarker"} 0.011
minecraft_dimension_ticktime_total{dimension="overworld",namespace="minecraft"} 8.436
minecraft_dimension_ticktime_total{dimension="prison",namespace="minecells"} 0.008
minecraft_dimension_ticktime_total{dimension="promenade",namespace="minecells"} 0.008
minecraft_dimension_ticktime_total{dimension="ramparts",namespace="minecells"} 0.011
minecraft_dimension_ticktime_total{dimension="spatial_storage",namespace="ae2"} 0.008
minecraft_dimension_ticktime_total{dimension="the_bumblezone",namespace="the_bumblezone"} 0.01
minecraft_dimension_ticktime_total{dimension="the_end",namespace="minecraft"} 0.009
minecraft_dimension_ticktime_total{dimension="the_nether",namespace="minecraft"} 0.013
minecraft_dimension_ticktime_total{dimension="venus",namespace="ad_astra"} 0.008
minecraft_dimension_ticktime_total{dimension="venus_orbit",namespace="ad_astra"} 0.028
# TYPE minecraft_dimension_tps_total counter
minecraft_dimension_tps_total{dimension="black_bridge",namespace="minecells"} 20
minecraft_dimension_tps_total{dimension="earth_orbit",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="glacio",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="glacio_orbit",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="glassocean",namespace="spellbladenext"} 20
minecraft_dimension_tps_total{dimension="insufferable_crypt",namespace="minecells"} 20
minecraft_dimension_tps_total{dimension="mars",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="mars_orbit",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="mercury",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="mercury_orbit",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="moon",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="moon_orbit",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="otherside",namespace="deeperdarker"} 20
minecraft_dimension_tps_total{dimension="overworld",namespace="minecraft"} 20
minecraft_dimension_tps_total{dimension="prison",namespace="minecells"} 20
minecraft_dimension_tps_total{dimension="promenade",namespace="minecells"} 20
minecraft_dimension_tps_total{dimension="ramparts",namespace="minecells"} 20
minecraft_dimension_tps_total{dimension="spatial_storage",namespace="ae2"} 20
minecraft_dimension_tps_total{dimension="the_bumblezone",namespace="the_bumblezone"} 20
minecraft_dimension_tps_total{dimension="the_end",namespace="minecraft"} 20
minecraft_dimension_tps_total{dimension="the_nether",namespace="minecraft"} 20
minecraft_dimension_tps_total{dimension="venus",namespace="ad_astra"} 20
minecraft_dimension_tps_total{dimension="venus_orbit",namespace="ad_astra"} 20

On Prominence II.

Note: It requires the Fabric TPS mod (No affiliation), as there is no native TPS method.
While this pack has spark built in, it's still not ideal.

The nice thing about the Fabric TPS mod is it outputs the same format as /forge tps which allows us to reuse that code block.

Unfortunately, there is no way to easily capture entities.
I had tried using something like execute as @e run say @s which puts out a list like:

Bee
Mimic
Mimic
[Minecart with TNT]: Minecart with TNT
Bluejay
Drake
Drake
[Amethyst Golem]: Amethyst Golem
Drake
Drake
Painting
Mimic
Wolf
Wolf
Mimic
Glare
Glare
Glare
Glare
Duck
Duck
Duck
Glare
[Minecart with Chest]: Minecart with Chest
[Minecart with Chest]: Minecart with Chest
[Minecart with Chest]: Minecart with Chest
Drake
[Frozen Flower]: Frozen Flower
[Minecart with Chest]: Minecart with Chest
[Giant Geckotoa]: Giant Geckotoa
[Minecart with Chest]: Minecart with Chest
[Brown Mushroom]: Brown Mushroom
Lizard
Mimic
Mimic
Mimic
[Amethyst Golem]: Amethyst Golem
Rabbit
[Minecart with Chest]: Minecart with Chest
Bluejay

By looping through the output. However, this not only logs to the users in-game; but also the rcon plugin doesn't get a response; it's an empty string. So we can't do much with that.

Also verify you have:

Signed-off-by: Mx772 <drewcarter0@gmail.com>
Signed-off-by: Mx772 <drewcarter0@gmail.com>
@Mx772 Mx772 requested a review from dirien as a code owner June 20, 2024 21:26
Copy link
Owner

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mx772,

Thanks for the PR and the delayed (😅) review. Tested it on 1.21.1 with Fabric 0.16.5 and it LGTM.

@dirien dirien merged commit fedbd56 into dirien:main Sep 29, 2024
1 check passed
@Mx772 Mx772 deleted the fabric_support branch September 29, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants