Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] fixes broken spaces logic #929

Merged
merged 1 commit into from
Sep 29, 2024
Merged

[main] fixes broken spaces logic #929

merged 1 commit into from
Sep 29, 2024

Conversation

Mx772
Copy link
Contributor

@Mx772 Mx772 commented May 6, 2024

Opening PR for #770

Note: I did not write this; however, I was hitting this error in my instance and went to fix it and found someone had opened an issue but not closed/pr'd it.

Thank you for making Minecraft Exporter for Prometheus better

Please reference the issue this PR is fixing.

Also verify you have:

@Mx772 Mx772 requested a review from dirien as a code owner May 6, 2024 01:12
@Mx772 Mx772 changed the title fixes broken places logic fixes broken spaces logic May 6, 2024
@Mx772 Mx772 changed the title fixes broken spaces logic [main] fixes broken spaces logic May 6, 2024
@Mx772
Copy link
Contributor Author

Mx772 commented May 6, 2024

Note:

Those links in the PR template md are broken it seems:

Not sure if it just doesn't support self-linking like that anymore of what; but to hard-code it:

Opening PR for dirien#770

Signed-off-by: Mx772 <drewcarter0@gmail.com>
Copy link

sonarcloud bot commented May 6, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Mx772
Copy link
Contributor Author

Mx772 commented May 6, 2024

Was able to build & test this locally; can confirm this works.

@dirien
Copy link
Owner

dirien commented May 11, 2024

hey @Mx772,

thanks for the PR. I will have a look into it.

@dirien dirien self-assigned this May 11, 2024
Copy link
Owner

@dirien dirien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Mx772,

Thanks for the PR. LGTM:

# HELP minecraft_player_online_total Players currently online (1 if player is online)
# TYPE minecraft_player_online_total counter
minecraft_player_online_total{player="_diri"} 1
minecraft_player_online_total{player="ediri"} 1

@dirien dirien merged commit 8e69a41 into dirien:main Sep 29, 2024
2 checks passed
@Mx772 Mx772 deleted the patch-1 branch September 29, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants