Update BaseStorage #9985
Merged
Update BaseStorage #9985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove dublicate strings into variables
rijkvanzanten
requested changes
Nov 22, 2021
Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
rijkvanzanten
approved these changes
Dec 1, 2021
rijkvanzanten
added a commit
that referenced
this pull request
Dec 1, 2021
* Update BaseStorage remove dublicate strings into variables * Apply suggestions from code review Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com> * Use enum types in keys Co-authored-by: Rijk van Zanten <rijkvanzanten@me.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove dublicate strings into variables