Bugfix: Exit on programmatic apply #110
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #99, which reports that the cli process fails to exit when applying a template. This is true when running in programmatic mode.
The root cause is that the last commit (#aa0dda7, #83) removed the
ux.exit(0)call after the'Template applied successfully.'log message within therunProgrammaticfunction — well, in fact, the line was commented out rather than deleted.For reference,
runInteractiveends withWhereas
runProgrammaticends withBefore the change,
runProgrammaticended withIt seems more than likely that commenting out
ux.exit(0)was unintentional while updating the console logs. Maybe @bryantgillespie, who did that change, could take a quick look and potentially merge this and release a fixed version to restore the proper exit behavior in CI environments. 🤞