Add binning on output #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoolFanyu
approved these changes
Aug 12, 2025
CoolFanyu
approved these changes
Aug 12, 2025
CoolFanyu
approved these changes
Aug 12, 2025
CoolFanyu
approved these changes
Aug 12, 2025
CSSFrancis
commented
Aug 12, 2025
Comment on lines
+2156
to
+2163
| def get_image( | ||
| self, | ||
| frame_type: Union[FrameType, str] = FrameType.SUMTOTAL, | ||
| pixel_format: Union[PixelFormat, str] = PixelFormat.AUTO, | ||
| attributes: Union[Attributes, str] = "auto", | ||
| file_name: str = None, | ||
| text_size: int = 0, | ||
| ): |
Member
Author
There was a problem hiding this comment.
@CoolFanyu I did change this slightly to allow any attribute to be passed to the get_image function.
Collaborator
There was a problem hiding this comment.
Yes, that should be better. I noticed some old scripts used this function. In most cases, it just calls GetImage(). But it also added some other parameters in some scripts, and I noticed they are also not compatible with SDK 5.2. I guess we should just use the new one and change the old script if it passes parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the additional attributes:
It also increments the version number to support the beta version of 2.7.5.