Skip to content

Commit

Permalink
[3251] Improvement: fix assertion (apache#3263)
Browse files Browse the repository at this point in the history
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[apache#123] feat(operator): support xxx"
     - "[apache#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[apache#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?
Fixed assertion



Fix:  apache#3251

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Ran test locally multiple times

---------

Signed-off-by: Rohit Satya <work.rohitsatya@gmail.com>
  • Loading branch information
rohit-satya authored and diqiu50 committed Jun 13, 2024
1 parent 89ab003 commit 09ebdca
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ public void testCreateCatalog() throws Exception {
assertThat(computeActual("show catalogs").getOnlyColumnAsSet()).contains("memory");

// testing the gravitino connector framework works.
assertThat(computeActual("select * from system.jdbc.tables"));
assertThat(computeActual("select * from system.jdbc.tables").getRowCount()).isGreaterThan(1);

// test metalake named test. the connector name is gravitino
assertUpdate("call gravitino.system.create_catalog('memory1', 'memory', Map())");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ public void testCreateCatalog() throws Exception {
assertThat(computeActual("show catalogs").getOnlyColumnAsSet()).contains("test.memory");

// testing the gravitino connector framework works.
assertThat(computeActual("select * from system.jdbc.tables"));
assertThat(computeActual("select * from system.jdbc.tables").getRowCount()).isGreaterThan(1);

// test metalake named test. the connector name is gravitino
assertUpdate("call gravitino.system.create_catalog('memory1', 'memory', Map())");
Expand Down

0 comments on commit 09ebdca

Please sign in to comment.