feat: add meta for toc in head link #710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3y3
reviewed
Mar 29, 2024
src/utils/markup.ts
Outdated
| @@ -46,13 +58,18 @@ export function generateStaticMarkup( | |||
| const html = staticContent ? render(props) : ''; | |||
| const isRTL = RTL_LANGS.includes(props.lang); | |||
|
|
|||
| const headMeta = generateTags('meta', tocHead?.meta); | |||
| const headLink = generateTags('link', tocHead?.link); | |||
|
|
|||
| return ` | |||
| <!DOCTYPE html> | |||
| <html lang="${props.lang}" dir="${isRTL ? 'rtl' : 'ltr'}"> | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| ${getMetadata(metadata, restYamlConfigMeta)} | |||
There was a problem hiding this comment.
А вот это не дублирует headMeta чуть ниже?
There was a problem hiding this comment.
Там только <script /> и <link rel="stylesheet" type="text/css" />.
Те такой вариант дает менять стили в более гибком варианте. Хотя цель этого не дать добавлять стили, а дать добавить og теги и другие теги для треков и интеграций с непостоянным наполнением ([name]="value').
There was a problem hiding this comment.
Переделал решение под то что уже есть. Таким образом добавил опциональное поле tagName для возможности проставить <${tagName} {...args} />
|
добавь, пожалуйста, тестов для добавления меты |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.