Skip to content

Commit

Permalink
Moved driver to own module and finished it.
Browse files Browse the repository at this point in the history
Added leds task.
Started on measure task.
  • Loading branch information
diondokter committed Aug 13, 2023
1 parent f40a14b commit b10c2a4
Show file tree
Hide file tree
Showing 7 changed files with 188 additions and 48 deletions.
20 changes: 19 additions & 1 deletion software/ih-controller-firmware/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions software/ih-controller-firmware/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ futures = { version = "0.3.17", default-features = false, features = ["async-awa
rmodbus = { version = "0.7.4", default-features = false, features = ["heapless"] }
static_cell = { version = "1.2.0", features = ["nightly"] }
heapless = { version = "0.7.16", features = ["defmt"] }
stm32g0 = { version = "0.15", default-features = false, features = ["stm32g030"] }

[profile.release]
lto = true
Expand Down
67 changes: 67 additions & 0 deletions software/ih-controller-firmware/src/driver.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
use core::pin::pin;

use embassy_futures::select::{select3, Either3};
use embassy_stm32::{
peripherals::TIM1,
time::Hertz,
timer::{complementary_pwm::ComplementaryPwm, Channel},
};
use futures::StreamExt;

use crate::modbus;

#[embassy_executor::task]
pub async fn driver(mut driver_pwm: ComplementaryPwm<'static, TIM1>) -> ! {
let mut enable_listener = pin!(modbus::ENABLE.get_listener().await);
let mut frequency_listener = pin!(modbus::DRIVE_FREQUENCY.get_listener().await);
let mut dutycycle_listener = pin!(modbus::COIL_POWER_DUTYCYCLE.get_listener().await);

// We want the timer to be able to trigger the ADC.
// For that we set the MMS2 to `0101: Compare - OC2REFC signal is used as trigger output (TRGO2)`
// The adc can then trigger on the TRGO2 signal
unsafe { &*stm32g0::stm32g030::TIM1::PTR }
.cr2
.modify(|_, w| w.mms2().variant(0b0101));

driver_pwm.set_dead_time(0);

modbus::ENABLE.write(false).await;
modbus::DRIVE_FREQUENCY.write(40_000).await;
modbus::COIL_POWER_DUTYCYCLE.write(1.0).await;

loop {
let result = select3(
enable_listener.next(),
frequency_listener.next(),
dutycycle_listener.next(),
)
.await;

match result {
Either3::First(Some(enable)) => {
if enable {
driver_pwm.enable(Channel::Ch2);
} else {
driver_pwm.disable(Channel::Ch2);
}

modbus::LED_GREEN.write(enable).await;
}
Either3::Second(Some(frequency)) => {
driver_pwm.set_freq(Hertz(frequency));
let dutycycle = modbus::COIL_POWER_DUTYCYCLE.read().await;
driver_pwm.set_duty(
Channel::Ch2,
(driver_pwm.get_max_duty() as f32 * dutycycle.clamp(0.0, 1.0)) as u16,
);
}
Either3::Third(Some(dutycycle)) => {
driver_pwm.set_duty(
Channel::Ch2,
(driver_pwm.get_max_duty() as f32 * dutycycle.clamp(0.0, 1.0)) as u16,
);
}
_ => defmt::unreachable!(),
}
}
}
31 changes: 31 additions & 0 deletions software/ih-controller-firmware/src/leds.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
use core::pin::pin;

use crate::modbus;
use embassy_futures::select::{select, Either};
use embassy_stm32::{
gpio::OutputOpenDrain,
peripherals::{PA1, PA2},
};
use futures::StreamExt;

#[embassy_executor::task]
pub async fn leds(
mut led_g: OutputOpenDrain<'static, PA2>,
mut led_r: OutputOpenDrain<'static, PA1>,
) -> ! {
let mut led_g_listener = pin!(modbus::LED_GREEN.get_listener().await);
let mut led_r_listener = pin!(modbus::LED_RED.get_listener().await);

modbus::LED_GREEN.write(false).await;
modbus::LED_RED.write(false).await;

loop {
let result = select(led_g_listener.next(), led_r_listener.next()).await;

match result {
Either::First(Some(value)) => led_g.set_level(value.into()),
Either::Second(Some(value)) => led_r.set_level(value.into()),
_ => defmt::unreachable!(),
}
}
}
55 changes: 15 additions & 40 deletions software/ih-controller-firmware/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,11 @@
#![no_main]
#![feature(type_alias_impl_trait)]

use core::pin::pin;

use embassy_executor::Spawner;
use embassy_futures::select::{select4, Either4};
use embassy_stm32::{
bind_interrupts,
gpio::{Level, OutputOpenDrain, OutputType, Pull, Speed},
peripherals::{self, TIM1, USART1},
peripherals::{self, USART1},
rcc::{ClockSrc, PllConfig},
time::khz,
timer::{
Expand All @@ -18,10 +15,11 @@ use embassy_stm32::{
},
usart::{self, Uart},
};
use futures::StreamExt;
use modbus::modbus_server;
use {defmt_rtt as _, panic_probe as _};

mod driver;
mod leds;
mod measure;
pub mod modbus;

bind_interrupts!(struct Irqs {
Expand All @@ -43,11 +41,12 @@ async fn run(spawner: Spawner) {
.cfgr1()
.modify(|w| w.set_pa11_rmp(true));

let adc = p.ADC1;
let analog_l = p.PA0; // ADC_IN0
let measure_adc = p.ADC1;
let measure_pin = p.PA0; // ADC_IN0
let measure_dma = p.DMA1_CH3;

let led_r = OutputOpenDrain::new(p.PA1, Level::High, Speed::Low, Pull::None);
let led_g = OutputOpenDrain::new(p.PA2, Level::High, Speed::Low, Pull::None);
let led_r = OutputOpenDrain::new(p.PA1, Level::High, Speed::Low, Pull::None);

let config = usart::Config::default();
let rs485 = Uart::new_with_de(
Expand All @@ -67,36 +66,12 @@ async fn run(spawner: Spawner) {
khz(40),
);

let fan_tacho_timer = p.TIM17;
let fan_tacho = p.PB9; // CH1
// TODO input capture for fan tacho

spawner.must_spawn(modbus_server(0, rs485));
}

#[embassy_executor::task]
async fn driver(mut driver_pwm: ComplementaryPwm<'static, TIM1>) -> ! {
let mut enable_listener = pin!(modbus::ENABLE.get_listener().await);
let mut frequency_listener = pin!(modbus::DRIVE_FREQUENCY.get_listener().await);
let mut measure_frequency_listener = pin!(modbus::COIL_MEASURE_FREQUENCY.get_listener().await);
let mut dutycycle_listener = pin!(modbus::COIL_POWER_DUTYCYCLE.get_listener().await);

driver_pwm.set_dead_time(0);

loop {
let result = select4(
enable_listener.next(),
frequency_listener.next(),
measure_frequency_listener.next(),
dutycycle_listener.next(),
)
.await;
let _fan_tacho_timer = p.TIM17;
let _fan_tacho = p.PB9; // CH1
// TODO input capture for fan tacho

match result {
Either4::First(enable) => todo!(),
Either4::Second(_) => todo!(),
Either4::Third(_) => todo!(),
Either4::Fourth(_) => todo!(),
}
}
spawner.must_spawn(leds::leds(led_g, led_r));
spawner.must_spawn(modbus::modbus_server(0, rs485));
spawner.must_spawn(driver::driver(driver_pwm));
spawner.must_spawn(measure::measure(measure_adc, measure_pin, measure_dma));
}
48 changes: 48 additions & 0 deletions software/ih-controller-firmware/src/measure.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
use embassy_stm32::{dma::TransferOptions, pac::ADC1, peripherals};
use embassy_time::Duration;

use crate::modbus;

#[embassy_executor::task]
pub async fn measure(
_measure_adc: peripherals::ADC1,
_measure_pin: peripherals::PA0,
mut measure_dma: peripherals::DMA1_CH3,
) -> ! {
// What we need from the ADC is not implemented in embassy, so we'll have to control the registers ourselves.
// We take the peripherals nonetheless so we know we've got exclusive access

modbus::COIL_MEASURE_FREQUENCY.write(10).await;

let mut adc_sample_buffer = [0u16; 64];

// TODO: Configure the ADC and the pin

loop {
embassy_time::Timer::after(Duration::from_hz(
modbus::COIL_MEASURE_FREQUENCY.read().await.clamp(1, 1000) as u64,
))
.await;

if !modbus::ENABLE.read().await {
continue;
}

// TODO: Make the ADC start on the next TRGO2 (either rising edge or falling edge, needs figuring out)

let dma_transfer = unsafe {
embassy_stm32::dma::Transfer::new_read::<u16>(
&mut measure_dma,
5, // ADC request
ADC1.dr().as_ptr().cast(), // The result register of the adc
&mut adc_sample_buffer,
TransferOptions::default(),
)
};

dma_transfer.await;

// TODO: Do ADC cleanup
// TODO: Take the samples and do the calculations
}
}
14 changes: 7 additions & 7 deletions software/ih-controller-firmware/src/modbus.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ use rmodbus::server::context::ModbusContext;
use rmodbus::server::ModbusFrame;
use rmodbus::ModbusFrameBuf;

static MODBUS_CONTEXT: Mutex<ThreadModeRawMutex, ModbusContext<0, 2, 8, 8>> =
Mutex::<ThreadModeRawMutex, _>::new(ModbusContext::<0, 2, 8, 8>::new());
static MODBUS_CONTEXT: Mutex<ThreadModeRawMutex, ModbusContext<8, 8, 8, 8>> =
Mutex::<ThreadModeRawMutex, _>::new(ModbusContext::new());

static MODBUS_LISTENER_REGISTRATIONS: Mutex<
ThreadModeRawMutex,
Expand Down Expand Up @@ -234,16 +234,16 @@ fn ranges_overlap(x: RangeInclusive<u16>, y: RangeInclusive<u16>) -> bool {

// ----- Control (holdings) -----
/// The amount of times per second the heater coil resonance frequency and voltage max is measured
pub const COIL_MEASURE_FREQUENCY: ModbusRegister<f32, Holdings> = ModbusRegister::new(0);
pub const COIL_MEASURE_FREQUENCY: ModbusRegister<u16, Holdings> = ModbusRegister::new(0);
/// The dutycycle of the PWM that drives the coil. 0..=1
pub const COIL_POWER_DUTYCYCLE: ModbusRegister<f32, Holdings> = ModbusRegister::new(2);
pub const COIL_POWER_DUTYCYCLE: ModbusRegister<f32, Holdings> = ModbusRegister::new(1);
// ----- Control (coils) -----
pub const ENABLE: ModbusRegister<bool, Coils> = ModbusRegister::new(0);

// ----- Report (inputs) -----
pub const DRIVE_FREQUENCY: ModbusRegister<f32, Inputs> = ModbusRegister::new(0);
pub const FAN_RPM: ModbusRegister<f32, Inputs> = ModbusRegister::new(2);
pub const COIL_VOLTAGE_MAX: ModbusRegister<f32, Inputs> = ModbusRegister::new(4);
pub const DRIVE_FREQUENCY: ModbusRegister<u32, Inputs> = ModbusRegister::new(0);
pub const FAN_RPM: ModbusRegister<u16, Inputs> = ModbusRegister::new(2);
pub const COIL_VOLTAGE_MAX: ModbusRegister<f32, Inputs> = ModbusRegister::new(3);
// ----- Report (discretes) -----
pub const LED_GREEN: ModbusRegister<bool, Discretes> = ModbusRegister::new(0);
pub const LED_RED: ModbusRegister<bool, Discretes> = ModbusRegister::new(1);
Expand Down

0 comments on commit b10c2a4

Please sign in to comment.