Add MountingHole Mechanical plating option #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…connectors - Add 'Mechanical' option to MountingHole Plating enum for non-plated holes - Update MountingHole footprint logic to handle Via and Mechanical plating - Mechanical holes now use MountingHole symbol (no pad) and have no pins - Copy MolexPicoBlade to connectors/ directory with test file - Add deprecation warning to kicad/MolexPicoBlade.zen
- Add JstGh.zen with PinCount (2-14) and Orientation enums - Update MolexPicoBlade and JstGh to pass mpn/manufacturer directly to Component - Remove Properties() usage in favor of direct properties dict - Add test file for JST GH connector
nasheed-x
changed the title
akhilles
reviewed
Dec 16, 2025
Contributor
akhilles
left a comment
akhilles
left a comment
There was a problem hiding this comment.
Mounting hole changes lgtm.
connectors/MolexPicoBlade.zen
Outdated
Contributor
There was a problem hiding this comment.
Should we just move this to registry instead? Not really sure it belongs in the stdlib.
connectors/JstGh.zen
Outdated
generics/MountingHole.zen
Outdated
Comment on lines
16
to
18
| diameter = config("diameter", Diameter, convert=Diameter) | ||
| standard = config("standard", Standard, default=Standard("DIN965"), convert=Standard, optional=True) | ||
| plating = config("plating", Plating, default=Plating("TopBottom"), convert=Plating, optional=True) |
Contributor
There was a problem hiding this comment.
you don't need the convert= anymore for enums
nasheed-x
changed the title
akhilles
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Note: MolexPicoBlade and JstGh connectors have been moved to the registry repo.