Used strong comparison and prevented remote selection of hash algorithm #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dintel
added a commit
that referenced
this pull request
Nov 12, 2015
Used strong comparison and prevented remote selection of hash algorithm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comparison of strings should be strict to prevent this bug: https://3v4l.org/0KPn4
Also, at the moment GitHub only use SHA-1 for signing payloads. Allowing the sender of the payload to pick the hashing algorithm free format creates an opportunity to use a weaker algorithm when carrying out a brute force attack (such as one exploiting the weak string comparison).