Clean up floppy signature detection code. #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…heck this is more obvious to read at a glance.
Collaborator
|
Please split your changes into two separate commits. Bundling unrelated changes together isn't recommended because it makes further testing and fixing harder. Thank you in advance! |
Contributor
Author
|
They're already two separate commits, do you want them as two PRs? |
Owner
|
That would be preferred, yes. |
mrpapersonic
force-pushed
the
floppy-cleanup
branch
from
71a8877 to
03ec9d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It took me a second to figure out what the code was doing originally. All I did was separate out the crux of the logic into a lambda function rather than a for-loop.
Also includes a build fix for Linux machines linking with libstdc++.