Implement new api:routes command.

[hskrasek]

Below is my implementation of the api:routes command. Functions basically the same as the base routes command but with different data.

No tests included, since I have no idea how you would even test Artisan commands.

[jasonlewis]

Bind it in the container as dingo.api.command.routes.

[jasonlewis]

This looks really solid @hskrasek. Only things I'm going to want you to change are to use tabs instead of spaces, opening brace should be on a new line, use the literal array syntax [] instead of array()... And, I think that's it. This is kind of like Laravel, doesn't really follow PSR-2.

And don't worry about testing. 😄

[Anahkiasen]

Why does this not use Symfony's Table helper like Artisan's command route ? That'd be much more solid

[jasonlewis]

It does, doesn't it?

$this->table = $this->getHelperSet()->get('table');

[hskrasek]

It basically is an exact clone of the Artisan routes command. With the addition of maybe one function, and small changes here and there :P.

@jasonlewis I shall make those changes now.

[Anahkiasen]

Ah yeah sorry I'm used to Symfony 2.5's helpers so I was looking for the use at the top of the file, my bad.

[jasonlewis]

Cheers @hskrasek, just refer to some of the other files for the style. 👍

[Anahkiasen]

Question then though: if dingo/api is meant for Laravel only, why not just extend RoutesCommand and override the relevant methods ?

[hskrasek]

@Anahkiasen I had tried that and ran into some errors at the time (can't remember the exact error, I've slept since then). I might look into extending the RoutesCommand again, but at the moment it functions all the same. That and if Otwell decides to change something all of a sudden with the RoutesCommand, it is less likely to break this command.

[jasonlewis]

@Anahkiasen Plus I think some sort of separation is required, especially if you have many API routes and many regular routes.

[Anahkiasen]

No I meant using the core code of it but still just displaying the API routes, just that when Laravel does update to 2.5's Table helper, you'd inherit that too. Since Laravel 4.2 comes with 2.5 components it's likely to happen soon.

[hskrasek]

@jasonlewis Style changes pushed up now.

And I believe @Anahkiasen is saying instead of ApiRoutesCommand extends Command, doing ApiRoutesCommand extends RoutesCommand and then just overriding what I need to override to display only the API Routes. It was something to do with parent::__construct(), if I remember correctly. I will mess around with it later today and see if I can get it to work that way, unless you want them seperated @jasonlewis

[Anahkiasen]

Yeah that's what I meant

[jasonlewis]

Ah yeah, makes sense, take a look and see if it would be possible @hskrasek. Otherwise I'll merge this in tomorrow (my time).

[jasonlewis]

This will need to be updated as well to reflect the new container binding.

[hskrasek]

@jasonlewis I was able to change up the command to extend the RoutesCommand. Everything seems to be in working order.

[Anahkiasen]

aw yiss, really waiting for this.

[hskrasek]

I haven't tested this, since I didn't even know the options existed until looking at the source, but this command should also support the filtering capabilities that the base Artisan routes command has.

[jasonlewis]

Merged this in locally and have now pushed it at 2dae069. Cheers @hskrasek.

[hskrasek]

Woot! No problem, now to find something else to try and contribute to in this package :P