Support for custom data includes in transformer #1575
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gazben
added a commit
to gazben/api
that referenced
this pull request
Sep 12, 2018
Fix dingo#1575 This is a resubmission of the pull request with proper formatting
|
@vruello I resubmitted your changes now the CI will accept it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for #1133 and related issues.
The attribute
lazyLoadedIncludesmust be declared public in the transformer to make it work. Otherwise, it would have been necessary to change Fractal library to add a getter.All the includes name listed in this array will not be loaded using eager loading. It is then possible to include custom data not linked to any relationship or model.