Fix matching prefix for api routes

[joecohens]

Hey mate!, I've fixed the prefix it was matching anything at the start of the string and it was causing 404s on the api routes. Also made a test on it.

I hope it helps, let me know! ;)

[jasonlewis]

Looks good. What was it causing 404s on exactly? Can you give me some sample code?

Also it looks like you're using spaces, any chance you can swap them for tabs. Cheers!

[joecohens]

Sorry for the spaces!.

Using:

Route::api(['version' => 'v1', 'prefix' => 'api', 'protected' => true], function()
{
    Route::post('token', ['protected' => false, function()
    {
          $payload = Input::only('grant_type', 'client_id', 'client_secret', 'username', 'password', 'scope');

          return API::issueToken($payload);
    }]);

    Route::get('users', ['protected' => true, function()
    {
          $user = User::all();

          return API::user();
    }]);
});

I was getting a NotFoundException, if I copy and pasted the same code below and change the version to v2, it worked. It was awkward.

Then if I was using the prefix 'api' and hitting '/apianything/users' it was working also.

So I figured it was the matcher for prefixes, and the bug was exactly in this line:

starts_with($request->getPathInfo(), trim($this->option('prefix'), '/'))

$request->getPathInfo() // Was /api/users

And the trim was made on the prefix that I've set on the route so it was 'api'.

Hope it was clear :)

[jasonlewis]

Okay it's a bug. But this still isn't going to fix it because it won't match a prefix that has a slash in it.

Route::api(['version' => 'v1', 'prefix' => 'foo/bar'], function()
{
    // Any routes in here would not be found.
});

Something like this should do the trick I think:

/**
 * Matches prefix if is set in route group
 *
 * @param $request
 * @return bool
 */
protected function matchPrefix($request)
{
    if ( ! $prefix = $this->option('prefix'))
    {
        return false;
    }

    $prefix = $this->filterAndExplode($this->option('prefix'));

    $path = $this->filterAndExplode($request->getPathInfo());

    return $prefix == array_slice($path, 0, count($prefix));
}

/**
 * Explode array on slash and remove empty values.
 * 
 * @param  array  $array
 * @return array
 */
protected function filterAndExplode($array)
{
    return array_filter(explode('/', $array));
}

[joecohens]

Totally right! I forgot the slashes.

I've updated the code with yours and the tests to match also prefixes with slashes

Excellent thanks for everything!

[jasonlewis]

Merged this in via command line to squash some commits.

e13f825

Cheers!

(I think you probably should've squashed them, ah well.)

[joecohens]

Thanks mate! Sorry I'm kind of new with best practices on PR, I'll doit next time.