Dingo responding to configuration from Route::group

[mrtimp]

After our testing last night I had the following defined in my routes.php file:

Route::group([ 'version' => 'v1', 'prefix' => 'api' ], function() {
Route::any('foo', function () {
return array("Hello" => "World");
});
});

When I did a composer update to pull in the latest version of Dingo I got a RuntimeException thrown from dingo/api/src/Routing/Router.php line 417:

There is no API collection for the version "v1"

Once I removed the Route::group composer would update correctly. Should Dingo ignore any parameters passed to a Route that isn't Route::api ?

[jasonlewis]

You must use Route::api not Route::group
On 17 Apr 2014 06:17, "Tim Philips" notifications@github.com wrote:

After our testing last night I had the following defined in my routes.php
file:

Route::group([ 'version' => 'v1', 'prefix' => 'api' ], function() {
Route::any('foo', function () {
return array("Hello" => "World");
});
});

When I did a composer update to pull in the latest version of Dingo I got
a RuntimeException thrown from dingo/api/src/Routing/Router.php line 417:

There is no API collection for the version "v1"

Once I removed the Route::group composer would update correctly. Should
Dingo ignore any parameters passed to a Route that isn't Route::api ?

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7
.

[mrtimp]

Yeah, I understand that.

It was more of an observation that Dingo seemed to be called for calls to Route::group. Wasn't sure if it was something that should or shouldn't be happening.

[jasonlewis]

I'll look into why it was being called, my guess is because of the version
option in the group.
On 17 Apr 2014 09:26, "Tim Philips" notifications@github.com wrote:

Yeah, I understand that.

It was more of an observation that Dingo seemed to be called for calls to
Route::group. Wasn't sure if it was something that should or shouldn't be
happening.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/7#issuecomment-40664719
.

[jasonlewis]

It turned out to be because the regular route group had a prefix of "api". All fixed now Tim. 😄