Incorrect responses after optimize

[terion-name]

I faced a problem that after php artisan optimize responses are breaking.

Details:

config/app

'providers' => array(
    ...
    'Dingo\Api\ApiServiceProvider',
)
'aliases' => array(
    ...
    'API' => 'Dingo\Api\Facades\API',
)

base class

use Dingo\Api\Routing\Controller;
abstract class ResourceControllerAbstract extends Controller {
    public function index()
    {
        $args = $this->checkArgs(func_get_args(), $this->resources->count() - 1);

        $data = $this->getResource($args)->paginate($this->listsPerPage);
        return $data;
    }
}

Now, if I run composer dump-autoload — everything works like a charm.
But if I run php artisan optimize...

use Dingo\Api\Routing\Controller;
abstract class ResourceControllerAbstract extends Controller {
    public function index()
    {
        $args = $this->checkArgs(func_get_args(), $this->resources->count() - 1);
        $data = $this->getResource($args)->paginate($this->listsPerPage);
        dd($data); // object(Illuminate\Pagination\Paginator)
        return $data;
    }
}

abstract class ApiControllerAbstract extends ResourceControllerAbstract {
    public function index()
    {
        try {
            $response = call_user_func_array(array('parent', 'index'), func_get_args());
            dd($response); // and here comes the magic! see below

            if ($response instanceof \Illuminate\Pagination\Paginator) {
                return ApiResponseFormatter::format($response);
            } else {
                return $response;
            }
        } catch (\Exception $e) {
            throw new NotFoundHttpException;
        }
    }
}

dd result

object(Illuminate\Http\Response)[306]
  public 'original' => string '{"total":2,"per_page":10,"current_page":1,"last_page":1,"from":1,"to":2,"data":[{"id":"535fb8d06e6c631f936cb2a3","name":"foo"},{"id":"535fb8d06e6c631f936cb2a4","name":"bar"}]}' (length=175)
  ...
  protected 'content' => string '{"total":2,"per_page":10,"current_page":1,"last_page":1,"from":1,"to":2,"data":[{"id":"535fb8d06e6c631f936cb2a3","name":"foo"},{"id":"535fb8d06e6c631f936cb2a4","name":"bar"}]}' (length=175)
  protected 'version' => string '1.0' (length=3)
  protected 'statusCode' => int 200
  protected 'statusText' => string 'OK' (length=2)
  protected 'charset' => null

It is a response with a string!

But if i again run composer dump-autoload — I get here an instanse of object(Illuminate\Pagination\Paginator) as it supposed to be and everything works ok.

[jasonlewis]

I'm not sure I'm following. What's being compiled that would throw this
off? Are you adding any of your own classes to the compiled file?

I'll take a closer look in the morning. Any more details you can give me on
how to replicate this would be good. Perhaps if you could simplify it a
touch.
On 30 Apr 2014 00:55, "Terion" notifications@github.com wrote:

I faced a problem that after php artisan optimize responses are breaking.

Details:

config/app

'providers' => array(
...
'Dingo\Api\ApiServiceProvider',)'aliases' => array(
...
'API' => 'Dingo\Api\Facades\API',)

base class

use Dingo\Api\Routing\Controller;abstract class ResourceControllerAbstract extends Controller {
public function index()
{
$args = $this->checkArgs(func_get_args(), $this->resources->count() - 1);

    $data = $this->getResource($args)->paginate($this->listsPerPage);
    return $data;
}}

Now, if I run composer dump-autoload — everything works like a charm.
But if I run php artisan optimize...

use Dingo\Api\Routing\Controller;abstract class ResourceControllerAbstract extends Controller {
public function index()
{
$args = $this->checkArgs(func_get_args(), $this->resources->count() - 1);
$data = $this->getResource($args)->paginate($this->listsPerPage);
dd($data); // object(Illuminate\Pagination\Paginator)
return $data;
}}

abstract class ApiControllerAbstract extends ResourceControllerAbstract {
public function index()
{
try {
$response = call_user_func_array(array('parent', 'index'), func_get_args());
dd($response); // and here comes the magic! see below

        if ($response instanceof \Illuminate\Pagination\Paginator) {
            return ApiResponseFormatter::format($response);
        } else {
            return $response;
        }
    } catch (\Exception $e) {
        throw new NotFoundHttpException;
    }
}}

dd result

object(Illuminate\Http\Response)[306]
public 'original' => string '{"total":2,"per_page":10,"current_page":1,"last_page":1,"from":1,"to":2,"data":[{"id":"535fb8d06e6c631f936cb2a3","name":"foo"},{"id":"535fb8d06e6c631f936cb2a4","name":"bar"}]}' (length=175)
...
protected 'content' => string '{"total":2,"per_page":10,"current_page":1,"last_page":1,"from":1,"to":2,"data":[{"id":"535fb8d06e6c631f936cb2a3","name":"foo"},{"id":"535fb8d06e6c631f936cb2a4","name":"bar"}]}' (length=175)
protected 'version' => string '1.0' (length=3)
protected 'statusCode' => int 200
protected 'statusText' => string 'OK' (length=2)
protected 'charset' => null

It is a response with a string!

But if i again run composer dump-autoload — I get here an instanse of
object(Illuminate\Pagination\Paginator) as it supposed to be and
everything works ok.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/20
.

[terion-name]

No, I don't add anything in compiled file.
I simply run composer dump-autoload — it works
run php artisan optimize — it breaks

To replicate, I assume, you should implement inheritance..
A base controller that extends Dingo Controller and a child controller that extends it. And, maybe this is also important, Controller alias in app config is default, only specified controllers extend Dingo Controller
Maybe something of these things affects so

[jasonlewis]

So what class is inheriting from these abstract controllers? I feel like I'm missing something here. What are you doing with the API exactly. Are you internally calling a route with the API and you're expecting an actual result but not getting it? I'm unable to replicate this.

My suggestion is to make things less abstract and see where the error is coming from.

I've tried to mimic what you've shown but can't get it to work.

I have a ResourceAbstractController.php that is just returning a paginated Post model.

abstract class ResourceControllerAbstract extends Dingo\Api\Routing\Controller {

    public function index()
    {
        return Post::paginate(2);
    }

}

I then have a concrete ApiController that extends from the abstract controller.

class ApiController extends ResourceControllerAbstract {

    public function index()
    {
        try
        {
            $response = call_user_func_array(['parent', 'index'], func_get_args());

            dd($response);
        }
        catch (Exception $exception)
        {
            dd($exception);
        }
    }

}

It dumps and kills the script, printing the result. If I run artisan optimize and hit this route directly I get the paginator instance. If I call the route internally from another route I get the paginator instance.

[terion-name]

So what class is inheriting from these abstract controllers?

A simple controller inherits then. It only inits resources.. Listen, do you use Vagrant? I think, I can give you this project sources (it is in early begining stage) baked with vagrant configuration and you'll can bring up vagrant and see this all by your eyes

[jasonlewis]

Yeah sure send it over if you can. I'll try and get around to looking at it later.

[terion-name]

https://mega.co.nz/#!skAFUIgQ!Dcgt-6PlON7PS2ZfwQW6WIKkjpy15hvyv9JnItiGTzM
Bring vagrant up and hit http://localhost:8080/api/users/
And there you can play with dd's in controllers mentioned above and with optimizations

[jasonlewis]

Okay, I still can't replicate this. Even with your Vagrant setup I'm not getting a string response anywhere. I'm not sure what else I can do here. You'll have to debug this further yourself as it's working fine for me.

[terion-name]

It's absolutely weird...
I've recorded a video with reproducing:
https://www.youtube.com/watch?v=ftOls9QuZ4g

[jasonlewis]

So what if you use Illuminate\Routing\Controller instead of the API controller? Does it still return a string there for you? Both return the paginator object correctly for me.

[terion-name]

if I comment out API controller in ResourceControllerAbstract:

//use Dingo\Api\Routing\Controller;
use Illuminate\Routing\Controller;

then... then results are the same O_o

moreover, if i run composer dump-autoload — I get Paginator in that dd(), and if I run composer dump-autoload -o — I get a string response! so this is caused not by compiled laravel, but by composer autoloader optimization...

[jasonlewis]

Yeah there's something wacky going on in here. I'm not sure if it's related to the API or not. My suggestion is to disable packages and see if something is causing problems somewhere.

[terion-name]

HOLY FUCKIN SHIT!!!

Optimized autoloader took /app/CRM/Contracts/ApiControllerAbstract.dump.php instead of t/app/CRM/Contracts/ApiControllerAbstract.php
😲 😲 😲
I'm dumb!

@jasonlewis sorry for your time =(((((

[jasonlewis]

Aha! No worries at all @terion-name I'm glad you got it sorted. 😄