feat(skills): add shared MCP compatibility facade - #456
Merged
Conversation
jmagar
force-pushed
the
feat/skills-over-mcp
branch
from
August 19, 2026 18:50
01090db to
c16a400
Compare
jmagar
force-pushed
the
feat/skills-over-mcp
branch
from
August 19, 2026 20:48
e625891 to
541771d
Compare
jmagar
force-pushed
the
feat/skills-over-mcp
branch
from
August 19, 2026 21:37
39a081f to
a0dd33f
Compare
jmagar
marked this pull request as ready for review
August 19, 2026 22:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a transport-neutral Agent Skills compatibility layer on top of Labby's existing native SEP implementation.
crate::skillsskills, withskills.list,skills.search,skills.get, andskills.readexpose_skillsgatingskills.getSecurity / compatibility decisions
skillstool is the fallback for older/tool-only clientsskills.readlab:read,lab, orlab:admin; help/schema remain catalog introspectionexpose_skills=falsehides the fallback tool and rejects forged direct callsFinal landing evidence
a0dd33f1a12d1e2029506ff7c465fe4a96d214c6fc4d3a1c2ad4f1e6ca1c50bded4b7d7e72b41095ea07f3609926879da146ea6e3e3afdd65784a73a-D warnings: green before the final docs/CI-only base rebase; final-head GitHub Clippy also green2024-11-05,2025-03-26,2025-06-18, and2025-11-25; all negotiated correctly, exposed the single fixedskillsfallback, and completed list/get/read. The final base rebase changed docs/CI only and the final branch-only change was a test feature gate, so runtime compatibility code was unchanged afterward.Adversarial review findings resolved
expose_skills=falsecompatibility-tool bypassFull-suite timing note
A later low-concurrency full-workspace stress pass exposed intermittent scheduler-sensitive failures in unchanged gateway pool timeout tests. The affected files have no branch diff, isolated/repeated runs passed or showed timing sensitivity, and no unrelated runtime changes were made. The required final-head GitHub test/gateway jobs are green.
Living implementation tracker:
docs/plans/skills-over-mcp-compat/PROGRESS.md. The merged tracker reflects the pre-landing checkpoint; this PR body is the authoritative final landing addendum because the PR was concurrently merged before a tracker-only follow-up could be pushed.