Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit for ComponentTokenInterface #380

Merged

Conversation

jaketimothy
Copy link
Contributor

@jaketimothy jaketimothy commented Dec 13, 2024

Addresses Hacken audit findings for DinariAdapterToken to support Plume Nest

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes missing coverage. Please review.

Project coverage is 91.62%. Comparing base (1fa1a29) to head (d327ea9).
Report is 5 commits behind head on feature/plume-nest.

Files with missing lines Patch % Lines
src/plume-nest/DinariAdapterToken.sol 93.02% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/plume-nest     #380      +/-   ##
======================================================
+ Coverage               88.81%   91.62%   +2.80%     
======================================================
  Files                      15       15              
  Lines                     724      740      +16     
  Branches                   89       92       +3     
======================================================
+ Hits                      643      678      +35     
+ Misses                     81       62      -19     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…able market price (#383)

* feat: stale price check and asset conversion math fix

* test: stale price test

* feat: reduce code complexity and compile size

* feat: more StalePrice error info

* feat: added stale price duration admin and reduced opt runs
@jaketimothy jaketimothy marked this pull request as draft December 20, 2024 00:42
@jaketimothy jaketimothy marked this pull request as ready for review December 30, 2024 17:59
@jaketimothy jaketimothy merged commit d408db1 into feature/plume-nest Dec 30, 2024
6 checks passed
@jaketimothy jaketimothy deleted the DSHARE-829-Audit-for-ComponentTokenInterface branch December 30, 2024 19:28
@jaketimothy jaketimothy restored the DSHARE-829-Audit-for-ComponentTokenInterface branch December 30, 2024 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants