Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DSHARE-923] Update Plume-nest dependencies and add AssetsOf method #377

Conversation

joshualyguessennd
Copy link
Contributor

https://dinari.atlassian.net/browse/DSHARE-923

Plume updated their ComponentToken interface. Update the plume repo dependency and add assetdOf method to https://github.com/dinaricrypto/sbt-contracts/blob/feature/plume-nest/src/plume-nest/DinariAdapterToken.sol

@jaketimothy
Copy link
Contributor

And fix the failing tests

@joshualyguessennd joshualyguessennd merged commit d84e957 into feature/plume-nest Dec 3, 2024
6 checks passed
Copy link

codecov bot commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.39%. Comparing base (e5f5984) to head (b452227).
Report is 1 commits behind head on feature/plume-nest.

Additional details and impacted files
@@                  Coverage Diff                   @@
##           feature/plume-nest     #377      +/-   ##
======================================================
+ Coverage               87.54%   88.39%   +0.85%     
======================================================
  Files                      15       15              
  Lines                     586      724     +138     
  Branches                   92       92              
======================================================
+ Hits                      513      640     +127     
- Misses                     70       81      +11     
  Partials                    3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants