remove lock logic xdshare #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## jake/hacken-audit-2311 #250 +/- ##
==========================================================
- Coverage 93.28% 93.08% -0.20%
==========================================================
Files 15 15
Lines 387 376 -11
Branches 82 81 -1
==========================================================
- Hits 361 350 -11
Misses 5 5
Partials 21 21 ☔ View full report in Codecov by Sentry. |
|
Can you open fixes against branch jake/hacken-audit-2311? |
joshualyguessennd
changed the base branch from
dinari/hacken
to
jake/hacken-audit-2311
|
The latest foundry has different syle formatting. Update with |
jaketimothy
requested changes
Nov 27, 2023
jaketimothy
approved these changes
Nov 27, 2023
jaketimothy
added a commit
that referenced
this pull request
Dec 7, 2023
* remove lock logic xdshare (#250) * remove lock logic xdshare * fmt * remove unused method and xdshare interface * disable missing inheritance * Josue guessennd/cu 8686h7gwj validate zero addresses xd share (#253) * remove lock logic xdshare * fmt * remove unused method and xdshare interface * disable missing inheritance * zero address check, xdshare initialization * fmt * use solidity naming convention (#254) * use solidity naming convention * rename with git * rename to XDShare * remove unused import (#259) * Josue guessennd/cu 8686h7h4r conform to cei pattern (#257) * update usdc to stablecoin var name * update emit to flag before state var changes * conform CEI * move before external call * feat: pass stablecoin to dualdistributor (#263) * chore: gitignore data * feat: pass stablecoin to dualdistributor * style: fmt * feat: remove unused ReentrancyGuard (#265) * docs: RESTRICTOR_ROLE comments (#264) * docs: RESTRICTOR_ROLE comments * test: fix test address collision * style: fmt * feat: minDistributionTime (#268) * feat: minDistributionTime * style: fmt * docs: natspec * docs: additional distribution comments (#269) * docs: more comments on distributor * style: fmt * test: testSetMinDistributionTime (#270) * chore: del MockdShareFactory * chore: add MockDShareFactory * chore: del WrappeddShare * chore: add WrappedDShare * chore: del XDShare --------- Co-authored-by: joshualyguessennd <75019812+joshualyguessennd@users.noreply.github.com>
jaketimothy
added a commit
that referenced
this pull request
Dec 12, 2023
jaketimothy
added a commit
that referenced
this pull request
Dec 13, 2023
* remove lock logic xdshare (#250) * remove lock logic xdshare * fmt * remove unused method and xdshare interface * disable missing inheritance * Josue guessennd/cu 8686h7gwj validate zero addresses xd share (#253) * remove lock logic xdshare * fmt * remove unused method and xdshare interface * disable missing inheritance * zero address check, xdshare initialization * fmt * use solidity naming convention (#254) * use solidity naming convention * rename with git * rename to XDShare * remove unused import (#259) * Josue guessennd/cu 8686h7h4r conform to cei pattern (#257) * update usdc to stablecoin var name * update emit to flag before state var changes * conform CEI * move before external call * feat: pass stablecoin to dualdistributor (#263) * chore: gitignore data * feat: pass stablecoin to dualdistributor * style: fmt * feat: remove unused ReentrancyGuard (#265) * docs: RESTRICTOR_ROLE comments (#264) * docs: RESTRICTOR_ROLE comments * test: fix test address collision * style: fmt * feat: minDistributionTime (#268) * feat: minDistributionTime * style: fmt * docs: natspec * docs: additional distribution comments (#269) * docs: more comments on distributor * style: fmt * test: testSetMinDistributionTime (#270) * docs: orderprocessor comments * feat: remove XDShare --------- Co-authored-by: joshualyguessennd <75019812+joshualyguessennd@users.noreply.github.com>
jaketimothy
deleted the
Josue-Guessennd/CU-8686h7gm3-Handle-Unrestricted-Locking-in-xdShare-Contract
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.