note decimals > 18 not supported (#65)

dinaricrypto · Jun 8, 2023 · 9c55a39 · 9c55a39
1 parent 2b566cc
commit 9c55a39
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 13 deletions.
diff --git a/.gas-snapshot b/.gas-snapshot
@@ -2,40 +2,40 @@ BridgedERC20Test:testBurn() (gas: 120688)
 BridgedERC20Test:testBurnUnauthorizedReverts() (gas: 149499)
 BridgedERC20Test:testMint() (gas: 85292)
 BridgedERC20Test:testMintUnauthorizedReverts() (gas: 70722)
-BridgedERC20Test:testSetDisclosures(string) (runs: 518, μ: 61230, ~: 68688)
-BridgedERC20Test:testSetName(string) (runs: 518, μ: 60693, ~: 68676)
+BridgedERC20Test:testSetDisclosures(string) (runs: 518, μ: 61172, ~: 68688)
+BridgedERC20Test:testSetName(string) (runs: 518, μ: 61266, ~: 68676)
 BridgedERC20Test:testSetRestrictor(address) (runs: 518, μ: 19498, ~: 19508)
-BridgedERC20Test:testSetSymbol(string) (runs: 518, μ: 61365, ~: 68720)
+BridgedERC20Test:testSetSymbol(string) (runs: 518, μ: 60248, ~: 68720)
 BridgedERC20Test:testTransfer() (gas: 102411)
 BridgedERC20Test:testTransferBannedFromReverts() (gas: 121423)
 BridgedERC20Test:testTransferBannedToReverts() (gas: 123682)
 BridgedERC20Test:testTransferRestrictedToReverts() (gas: 124610)
-DirectBuyIssuerTest:testCancelOrder(uint128,uint128,string) (runs: 518, μ: 355488, ~: 364116)
+DirectBuyIssuerTest:testCancelOrder(uint128,uint128,string) (runs: 518, μ: 356989, ~: 364132)
 DirectBuyIssuerTest:testCancelOrderNotFoundReverts() (gas: 32635)
-DirectBuyIssuerTest:testFillOrder(uint128,uint128,uint128,uint256) (runs: 518, μ: 309774, ~: 282755)
+DirectBuyIssuerTest:testFillOrder(uint128,uint128,uint128,uint256) (runs: 518, μ: 309474, ~: 282755)
 DirectBuyIssuerTest:testFillorderNoOrderReverts() (gas: 32425)
 DirectBuyIssuerTest:testGetInputValue(uint128) (runs: 518, μ: 35379, ~: 35423)
 DirectBuyIssuerTest:testInitialize(address,address) (runs: 518, μ: 7165877, ~: 7165877)
 DirectBuyIssuerTest:testRequestCancel() (gas: 244115)
 DirectBuyIssuerTest:testRequestCancelNotFoundReverts() (gas: 30082)
 DirectBuyIssuerTest:testRequestCancelNotRecipientReverts() (gas: 236477)
-DirectBuyIssuerTest:testRequestOrder(uint128) (runs: 518, μ: 195567, ~: 252373)
+DirectBuyIssuerTest:testRequestOrder(uint128) (runs: 518, μ: 194842, ~: 252373)
 DirectBuyIssuerTest:testRequestOrderCollisionReverts() (gas: 239042)
 DirectBuyIssuerTest:testRequestOrderPausedReverts() (gas: 53669)
 DirectBuyIssuerTest:testRequestOrderUnsupportedAssetReverts(address) (runs: 518, μ: 92971, ~: 92971)
 DirectBuyIssuerTest:testRequestOrderUnsupportedPaymentReverts(address) (runs: 518, μ: 95482, ~: 95482)
 DirectBuyIssuerTest:testRequestOrderWithPermit() (gas: 310013)
-DirectBuyIssuerTest:testReturnEscrow(uint128,uint256) (runs: 518, μ: 289813, ~: 285071)
+DirectBuyIssuerTest:testReturnEscrow(uint128,uint256) (runs: 518, μ: 289860, ~: 285071)
 DirectBuyIssuerTest:testSetFees(address) (runs: 518, μ: 24656, ~: 24656)
 DirectBuyIssuerTest:testSetOrdersPaused(bool) (runs: 518, μ: 28153, ~: 21699)
 DirectBuyIssuerTest:testSetTreasury(address) (runs: 518, μ: 24885, ~: 24885)
-DirectBuyIssuerTest:testTakeEscrow(uint128,uint256) (runs: 518, μ: 262870, ~: 246678)
+DirectBuyIssuerTest:testTakeEscrow(uint128,uint256) (runs: 518, μ: 262480, ~: 246678)
 OrderFeesTest:testRecoverInputValueFromFee(uint64,uint128) (runs: 518, μ: 22637, ~: 22985)
 OrderFeesTest:testRecoverInputValueFromFeeOnRemaining(uint64,uint128) (runs: 518, μ: 24043, ~: 24410)
 OrderFeesTest:testSetFee(uint64,uint64,uint8,uint128) (runs: 518, μ: 587179, ~: 726644)
 OrderFeesTest:testUSDC() (gas: 15625)
-SellOrderProcessorTest:testCancelOrder(uint128,uint128,string) (runs: 518, μ: 354776, ~: 354807)
-SellOrderProcessorTest:testFillOrder(uint128,uint128,uint256) (runs: 518, μ: 294414, ~: 307614)
+SellOrderProcessorTest:testCancelOrder(uint128,uint128,string) (runs: 518, μ: 354771, ~: 354801)
+SellOrderProcessorTest:testFillOrder(uint128,uint128,uint256) (runs: 518, μ: 293245, ~: 282745)
 SellOrderProcessorTest:testRequestOrder(uint128) (runs: 518, μ: 206666, ~: 211783)
 TransferRestrictorTest:testBanUnban(address) (runs: 518, μ: 29036, ~: 29028)
 TransferRestrictorTest:testSetResetKyc(address,uint8) (runs: 518, μ: 28784, ~: 32165)
diff --git a/src/BridgedERC20.sol b/src/BridgedERC20.sol
@@ -2,10 +2,10 @@
 pragma solidity ^0.8.18;
 
 // solady ERC20 allows EIP-2612 domain separator with `name` changes
-import "solady/tokens/ERC20.sol";
+import {ERC20} from "solady/tokens/ERC20.sol";
 import {AccessControlDefaultAdminRules} from
     "openzeppelin-contracts/contracts/access/AccessControlDefaultAdminRules.sol";
-import "./ITransferRestrictor.sol";
+import {ITransferRestrictor} from "./ITransferRestrictor.sol";
 
 /// @notice ERC20 with minter and blacklist.
 /// @author Dinari (https://github.com/dinaricrypto/issuer-contracts/blob/main/src/BridgedERC20.sol)
@@ -21,7 +21,7 @@ contract BridgedERC20 is ERC20, AccessControlDefaultAdminRules {
     string internal _name;
     string internal _symbol;
 
-    /// @dev URI to information
+    /// @dev URI to disclosure information
     string public disclosures;
     ITransferRestrictor public transferRestrictor;
 

diff --git a/src/issuer/OrderProcessor.sol b/src/issuer/OrderProcessor.sol
@@ -52,6 +52,7 @@ abstract contract OrderProcessor is
     bytes32 public constant ADMIN_ROLE = keccak256("ADMIN_ROLE");
     bytes32 public constant OPERATOR_ROLE = keccak256("OPERATOR_ROLE");
     bytes32 public constant PAYMENTTOKEN_ROLE = keccak256("PAYMENTTOKEN_ROLE");
+    /// @dev Tokens with decimals > 18 are not supported by current OrderFees implementation
     bytes32 public constant ASSETTOKEN_ROLE = keccak256("ASSETTOKEN_ROLE");
 
     address public treasury;