Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs upd: update vue-image-gallery.md #2055

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

hzpeng57
Copy link
Contributor

@hzpeng57 hzpeng57 commented Aug 8, 2023

I wrote a library (vue + photoswipe5) that I think would be useful to others.

@dimsemenov
Copy link
Owner

Thank you, the lib looks great. Can you please fix your demo example on stackbltz and at https://github.com/hzpeng57/vue-preview-imgs/blob/master/packages/example/src/App.vue

{
    src: 'https://farm4.staticflickr.com/3902/14985871946_86abb8c56f_b.jpg',
    msrc: 'https://farm4.staticflickr.com/3902/14985871946_86abb8c56f_m.jpg',
    alt: 'picture2',
    w: 900,
    h: 1200,
  }

The correct dimensions of that images are 1024x683 and not 900x1200.

@hzpeng57
Copy link
Contributor Author

Thank you for pointing out my mistake, I have corrected it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants