Fix syntax error near integer, and value NIL
#1128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since `pgloader` @ 11970bb, importing from MySQL 5.7 to Postgresql 11 with SSL triggers the following exception: ``` You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'integer' ``` Rather than casting to `integer`, we should be casting to `unsigned` or calling `floor(..)`.
|
Can you see #1127 and add a COALESCE to your query so that empty tables with a NULL result there are covered too? or maybe that's not necessary with your version of the SQL query? |
|
I can try that, but I actually tried my version too, and it appears to work fine with it versus without it. EDIT: I have a feeling that issue you linked is not related, but is indeed, another potential problem. |
|
I've pushed a fix for #1127 as well @dimitri. I tested it without it, and it breaks when you have an empty table. But, with the Minimal reproduction w/ fixes: https://streamable.com/hp6xj9 |
MrSaints
changed the title
integerinteger, and value NIL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
pgloader@ 11970bb, importing from MySQL 5.7 to Postgresql 11with SSL triggers the following exception:
Rather than casting to
integer, we should be casting tounsignedor calling
floor(..).