Skip to content

Implement tables row count ordering for MySQL. #1120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2020

Conversation

dimitri
Copy link
Owner

@dimitri dimitri commented Mar 28, 2020

This should help optimize the duration of migrating databases with very big
tables and lots of smaller ones. It might be a little too naive as far as
the optimisation goes, while still being an improvement on the default
alphabetical one.

Fixes #1099.

This should help optimize the duration of migrating databases with very big
tables and lots of smaller ones. It might be a little too naive as far as
the optimisation goes, while still being an improvement on the default
alphabetical one.

Fixes #1099.
Copy link
Collaborator

@phoe phoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code introduced in this change invokes undefined behaviour; I suspect there's more cases of that in pgloader.

I also suggest some stylistic changes.

@dimitri dimitri requested a review from phoe April 3, 2020 21:26
@dimitri dimitri merged commit 11970bb into master Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Order source tables by size descending to reduce migration time
2 participants