Urlencode connection string not working with &

[crazyhouse33]

In this commit d1fce37

You add support to allow urlencode some components of connection strings but it does not work if we try to url encode two components:

into {{ TARGET_CONNECTOR }}://user:password@{{ TARGET_DB }}?user={{ TARGET_USERNAME }}&password={{ TARGET_PASSWORD }}

Result in

ESRAP-PARSE-ERROR: At end of input

;

^ (Line 7, Column 0, Position 697)

In context LOAD-PGSQL-COMMAND:

While parsing KW-INTO. Expected:

 the character Tab

or the character Newline
or the character Return
or the character Space
or the string "--"
or the string "/*"
or the string "into"

While parsing ANOTHER-DSN-OPTION. Expected:

 the character & (AMPERSAND)

While parsing URI-PARAM. Expected:

 <end of input>

or anything but the character & (AMPERSAND)
An unhandled error condition has been signalled: At end of input

;

^ (Line 7, Column 0, Position 697)

In context LOAD-PGSQL-COMMAND:

While parsing KW-INTO. Expected:

 the character Tab

or the character Newline
or the character Return
or the character Space
or the string "--"
or the string "/*"
or the string "into"

While parsing ANOTHER-DSN-OPTION. Expected:

 the character & (AMPERSAND)

While parsing URI-PARAM. Expected:

 <end of input>

or anything but the character & (AMPERSAND)

What I am doing here?

At end of input

;

^ (Line 7, Column 0, Position 697)

In context LOAD-PGSQL-COMMAND:

While parsing KW-INTO. Expected:

 the character Tab

or the character Newline
or the character Return
or the character Space
or the string "--"
or the string "/*"
or the string "into"

While parsing ANOTHER-DSN-OPTION. Expected:

 the character & (AMPERSAND)

While parsing URI-PARAM. Expected:

 <end of input>

or anything but the character & (AMPERSAND)

[crazyhouse33]

Nevermind I was just using old docker image not containing your commit (update dockerhub image?)

[crazyhouse33]

Nop I built an image locally with your sources with latest version and cant make it work with the url encode technique.

pgsql client can connect but pgloader seems to do something weird with the special chars. We need a way to fully escape username and password. Password is really complex and contain ^[]=+:, username contains @

We cant use the var env method because the load is done from anothe db so they are two separates passwords:

The load file is:

load database
from {{ SOURCE_CONNECTOR }}://user:password@{{ SOURCE_DB }}?user={{ SOURCE_USERNAME }}&password={{ SOURCE_PASSWORD }}
into {{ TARGET_CONNECTOR }}://user:password@{{ TARGET_DB }}?user={{ TARGET_USERNAME }}&password={{ TARGET_PASSWORD }}

including only table names matching 'bla', 'blo' in schema 'public'
;

password and username are urlencoded.

I tried a bunch of other methods without success