-
-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add user type names for system case auto updates #32873
Conversation
form_types[DEDUPE_XMLNS] = gettext_lazy('Deduplication Rule') | ||
form_types[XMLNS_DHIS2] = gettext_lazy('DHIS2 Integration') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any reason not to add these to the SYSTEM_FORM_XMLNS_MAP
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SYSTEM_FORM_XMLNS_MAP
is being used in a few other functions to get form counts, so I was a little hesitant to alter it directly. Especially since adding in the extra mappings would exclude their form types from being counted in the previously mentioned functions. I'm not sure if this is an actual concern however, and if not then I could add them to SYSTEM_FORM_XMLNS_MAP
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking again at the usages of SYSTEM_FORM_XMLNS_MAP
I think it would make sense to add them to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, this is consistent with the conclusions in [CEP] System Forms Metadata Standardization
Love the change!
Product Description
Below is an example of the old representation of system updates in the case history table:
This has been updated with a more specific representation of system updates as follows:
Technical Summary
Link to ticket here
Currently, all system case updates are labelled as "System" in the "User Type" column in the case history table. This change adds more specific names for system updates, such as the automatic case update and deduplication rules.
Feature Flag
None
Safety Assurance
Safety story
Small UI update, have done local testing. Unit tests also exist for related code.
Automated test coverage
Unit tests exist for
get_user_type()
.QA Plan
No QA planned.
Rollback instructions
Labels & Review