Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add user type names for system case auto updates #32873

Merged
merged 8 commits into from
Apr 26, 2023

Conversation

zandre-eng
Copy link
Contributor

@zandre-eng zandre-eng commented Apr 24, 2023

Product Description

Below is an example of the old representation of system updates in the case history table:
Screenshot from 2023-04-24 10-07-52

This has been updated with a more specific representation of system updates as follows:
Screenshot from 2023-04-24 10-00-04

Technical Summary

Link to ticket here

Currently, all system case updates are labelled as "System" in the "User Type" column in the case history table. This change adds more specific names for system updates, such as the automatic case update and deduplication rules.

Feature Flag

None

Safety Assurance

Safety story

Small UI update, have done local testing. Unit tests also exist for related code.

Automated test coverage

Unit tests exist for get_user_type().

QA Plan

No QA planned.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@zandre-eng zandre-eng added the product/all-users-all-environments Change impacts all users on all environments label Apr 24, 2023
Comment on lines 188 to 189
form_types[DEDUPE_XMLNS] = gettext_lazy('Deduplication Rule')
form_types[XMLNS_DHIS2] = gettext_lazy('DHIS2 Integration')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any reason not to add these to the SYSTEM_FORM_XMLNS_MAP

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The SYSTEM_FORM_XMLNS_MAP is being used in a few other functions to get form counts, so I was a little hesitant to alter it directly. Especially since adding in the extra mappings would exclude their form types from being counted in the previously mentioned functions. I'm not sure if this is an actual concern however, and if not then I could add them to SYSTEM_FORM_XMLNS_MAP.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking again at the usages of SYSTEM_FORM_XMLNS_MAP I think it would make sense to add them to it.

Copy link
Contributor

@esoergel esoergel Apr 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, this is consistent with the conclusions in [CEP] System Forms Metadata Standardization

Love the change!

@zandre-eng zandre-eng merged commit f021e81 into master Apr 26, 2023
@zandre-eng zandre-eng deleted the ze/determine_if_user_or_update_rule branch April 26, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants