Fix for Short Cycle Detection Algorithm #851
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shubham1g5
reviewed
Apr 19, 2019
| @@ -0,0 +1,7060 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <h:html xmlns:h="http://www.w3.org/1999/xhtml" xmlns:orx="http://openrosa.org/jr/xforms" xmlns="http://www.w3.org/2002/xforms" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:jr="http://openrosa.org/javarosa" xmlns:vellum="http://commcarehq.org/xforms/vellum"> | |||
Contributor
There was a problem hiding this comment.
I wonder if it's possible to use a smaller form for the test case that can repro the issue. Current one is 7k lines of xml which is not ideal.
Member
Author
There was a problem hiding this comment.
Hey, agreed that this seems like a big form. It also adds more time to tests than I'm comfortable with, but I couldn't think of a way to specifically clean out only these question elements and retain the "Regression."
I'm not sure if it actually matters much to have the regression test for the future if it ends up causing issues. i'll mull it over a bit
shubham1g5
approved these changes
Apr 19, 2019
Contributor
shubham1g5
left a comment
shubham1g5
left a comment
There was a problem hiding this comment.
@ctsims Nice catch. Thanks for fixing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket Reference:
https://dimagi-dev.atlassian.net/browse/HI-572
Will implemented an algorithm to find the shortest cycle in dependency evaluation, but the directional of the graph was implemented backwards
IE: For a calculation
velocity = distance / time
it would create the dependency edge set
distance -> velocity
time -> velocity
rather than
velocity -> time
velocity -> distance
which was making the algorithm mistakenly miss the cycle and error out.
Also ensured that cyclical references are reported specifically as a parse error, which was not unified on the current reporting path. We can end up detecting them in two places.