Remove Unreachable Swiss Server URL From LetsEncryptTest - #3832
Open
conroy-ricketts wants to merge 1 commit into
Open
Remove Unreachable Swiss Server URL From LetsEncryptTest#3832conroy-ricketts wants to merge 1 commit into
conroy-ricketts wants to merge 1 commit into
Conversation
[AI] The swiss.commcarehq.org endpoint no longer accepts connections and failed the test on a connect timeout; its DST Root CA X3 coverage became obsolete once that root shifted to ISRG Root X1, which the test already checks directly. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
📝 WalkthroughWalkthroughThe Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
conroy-ricketts
marked this pull request as ready for review
July 27, 2026 19:24
conroy-ricketts
requested review from
a team,
Jignesh-dimagi,
OrangeAndGreen,
avazirna and
shubham1g5
and removed request for
a team
July 27, 2026 19:25
OrangeAndGreen
approved these changes
Jul 27, 2026
shubham1g5
approved these changes
Jul 28, 2026
Jignesh-dimagi
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Technical Summary
LetsEncryptTestwas failing with aSocketTimeoutExceptionconnecting toswiss.commcarehq.org:443. Dimagi no longer maintains that server, so the endpoint is permanently unreachable rather than transiently down and there is nothing to fix on the infrastructure side.The URL only existed to exercise the DST Root CA X3 chain during the 2021 Let's Encrypt root transition, and the inline comment already marked it removable after that root shifted to ISRG Root X1. The test covers ISRG Root X1 directly via
valid-isrgrootx1.letsencrypt.org, so deleting the Swiss check loses no certificate-chain coverage.Safety Assurance
Safety story
What gives confidence:
Risks to review:
Automated test coverage
LetsEncryptTestcontinues to verify certificate-chain handling against ISRG Root X1, the AWS-hosted CommCare HQ endpoint, and GlobalSign, so the root-of-trust conditions the test was written to catch are still covered.