Skip to content

Remove Unreachable Swiss Server URL From LetsEncryptTest - #3832

Open
conroy-ricketts wants to merge 1 commit into
commcare_2.64from
remove-swiss-server-from-test
Open

Remove Unreachable Swiss Server URL From LetsEncryptTest#3832
conroy-ricketts wants to merge 1 commit into
commcare_2.64from
remove-swiss-server-from-test

Conversation

@conroy-ricketts

Copy link
Copy Markdown
Contributor

Technical Summary

LetsEncryptTest was failing with a SocketTimeoutException connecting to swiss.commcarehq.org:443. Dimagi no longer maintains that server, so the endpoint is permanently unreachable rather than transiently down and there is nothing to fix on the infrastructure side.

The URL only existed to exercise the DST Root CA X3 chain during the 2021 Let's Encrypt root transition, and the inline comment already marked it removable after that root shifted to ISRG Root X1. The test covers ISRG Root X1 directly via valid-isrgrootx1.letsencrypt.org, so deleting the Swiss check loses no certificate-chain coverage.

Safety Assurance

Safety story

What gives confidence:

  • I ran the connected instrumentation suite and confirmed all tests pass with the Swiss URL removed.
  • I confirmed Dimagi no longer maintains the Swiss server, so no reachable replacement endpoint is being dropped.
  • Scope is one instrumentation test; no production code is touched.

Risks to review:

  • The test still depends on three live external endpoints and asserts HTTP/2 on each, so it remains vulnerable to the same class of failure if any of those hosts change. That exposure is pre-existing and not altered here.

Automated test coverage

LetsEncryptTest continues to verify certificate-chain handling against ISRG Root X1, the AWS-hosted CommCare HQ endpoint, and GlobalSign, so the root-of-trust conditions the test was written to catch are still covered.

[AI] The swiss.commcarehq.org endpoint no longer accepts connections and failed the test on a connect timeout; its DST Root CA X3 coverage became obsolete once that root shifted to ISRG Root X1, which the test already checks directly.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@conroy-ricketts conroy-ricketts self-assigned this Jul 27, 2026
@coderabbitai

coderabbitai Bot commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

The LetsEncryptTest instrumentation test no longer defines or requests the Swiss endpoint. Its getPassesWithoutException flow now performs the ISRG-root check followed by the existing CommCare and Google GET requests.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title accurately and concisely describes the main change: removing the unreachable Swiss URL from LetsEncryptTest.
Description check ✅ Passed The description covers the technical summary, safety story, and automated test coverage; omitting Product Description is acceptable for this invisible test-only change.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-swiss-server-from-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@conroy-ricketts
conroy-ricketts marked this pull request as ready for review July 27, 2026 19:24
@conroy-ricketts
conroy-ricketts requested review from a team, Jignesh-dimagi, OrangeAndGreen, avazirna and shubham1g5 and removed request for a team July 27, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants