Not hiding app spinner when Login page loads with a preset app ID (to…

[OrangeAndGreen]

https://dimagi.atlassian.net/browse/CCCT-2095

Product Description

Fixes a bug where the app spinner on the Login page would sometimes be hidden when it shouldn't be.
The spinner is no longer hidden for pre-loaded apps.

Technical Summary

The bug was related to when we decide to show/hide the app spinner. Generally, the logic is to show the spinner if there's more than one app installed. But when auto-logging in to Connect apps, we also added code to hide the spinner as an early attempt at "locking the page". However, with the addition of the side menu some of the logic relating to pre-loaded apps changed and caused the page to always configure that part of the UI with the spinner hidden.

Since the Login page is locked down during Login anyway (via modal dialogs while logging in), a safe fix seems to be just not hiding the spinner whenever there are multiple apps installed.

Feature Flag

None

Safety Assurance

Safety story

I tested various scenarios related to this part of the code (app switching, pre-loading, etc.):

• Initial page view
• Switching apps via the spinner
• Switching apps via the side menu
• Auto-logging into Connect apps

Automated test coverage

None

QA Plan

A video shared here shows steps to reproduce the bug.
Verify that the above is fixed, and also test various app switching and login scenarios.

[coderabbitai]

📝 Walkthrough

Walkthrough

This pull request modifies the auto-proceed logic in the login activity controller by removing a conditional branch that previously allowed proceeding when either a single ready app existed OR a preset app was found. The updated logic only proceeds when exactly one ready app is available, eliminating the preset-app consideration from this branch. The unused noApps variable is also removed as part of this simplification.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Login: App switching fix #3417: Complements this PR by ensuring presetAppId is updated when the user explicitly selects an app, since this PR removes automatic preset-app consideration from the auto-proceed logic.

Suggested reviewers

• shubham1g5
• avazirna
• conroy-ricketts
• Jignesh-dimagi

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately reflects the main change: not hiding the app spinner when the Login page loads with a preset app ID, which directly addresses the bug being fixed.
Description check	✅ Passed	The description covers all required sections: Product Description, Technical Summary, Feature Flag, Safety Assurance (with safety story, automated test coverage, and QA plan), and includes a Jira link.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch dv/fix/ccct-2095-login-spinner

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[conroy-ricketts]

Love the simple fixes!